Add PHP 8.0 on GitHub action and Fix Psalm issue

antidot-framework · Oct 27, 2021 · 73db6e1 · 73db6e1
1 parent 3a38011
commit 73db6e1
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/coding-standards.yml b/.github/workflows/coding-standards.yml
@@ -20,6 +20,7 @@ jobs:
           - "locked"
         php-version:
           - "7.4"
+          - "8.0"
         operating-system:
           - "ubuntu-latest"
 

diff --git a/.github/workflows/mutation-tests.yml b/.github/workflows/mutation-tests.yml
@@ -20,6 +20,7 @@ jobs:
           - "locked"
         php-version:
           - "7.4"
+          - "8.0"
         operating-system:
           - "ubuntu-latest"
 
@@ -60,4 +61,4 @@ jobs:
         env:
           INFECTION_BADGE_API_KEY: ${{ secrets.INFECTION_BADGE_API_KEY }}
           STRYKER_DASHBOARD_API_KEY: ${{ secrets.STRYKER_DASHBOARD_API_KEY }}
-  
+
diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml
@@ -20,6 +20,7 @@ jobs:
           - "locked"
         php-version:
           - "7.4"
+          - "8.0"
         operating-system:
           - "ubuntu-latest"
 

diff --git a/.github/workflows/psalm.yml b/.github/workflows/psalm.yml
@@ -20,6 +20,7 @@ jobs:
           - "locked"
         php-version:
           - "7.4"
+          - "8.0"
         operating-system:
           - "ubuntu-latest"
 

diff --git a/src/MiddlewarePipeline.php b/src/MiddlewarePipeline.php
@@ -53,7 +53,6 @@ function (ServerRequestInterface $request) {
                 /** @var string $requestId */
                 $requestId = $request->getAttribute('request_id');
                 try {
-                    /** @var MiddlewareInterface $middleware */
                     $middleware = $this->concurrentPipelines[$requestId]->dequeue();
 
                     $response = $middleware->process($request, $this);
@@ -84,7 +83,6 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
                 /** @var string $requestId */
                 $requestId = $request->getAttribute('request_id');
                 try {
-                    /** @var MiddlewareQueue $queue */
                     $queue = $this->concurrentPipelines[$requestId];
                     $next = new NextHandler($queue, $handler);