Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit_filter_spec is a huge (largely) untested hack #5

Open
antifuchs opened this issue Feb 26, 2013 · 0 comments
Open

emit_filter_spec is a huge (largely) untested hack #5

antifuchs opened this issue Feb 26, 2013 · 0 comments

Comments

@antifuchs
Copy link
Owner

The string manipulation it does is fairly ad-hoc and terrible, and there is exactly one test for it (prompted by #4). I think this should be way better.

The most glaring missing feature that I can think of is that top-level "OR" groups need has :or => [x,y]; you can't even use `has [{:or => [x,y]}] without superfluous parens. There are probably more of these cases.

=> Needs a bit of a rewrite (-:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant