Skip to content

Commit

Permalink
platform-checks: Add RenameCluster & RenameReplica
Browse files Browse the repository at this point in the history
Also reenable CreateCluster, DropCluster, CreateReplica, DropReplica as
they appear fixed, see MaterializeInc#13235
  • Loading branch information
def- authored and antiguru committed Jun 5, 2023
1 parent cab1af3 commit 915ea5f
Show file tree
Hide file tree
Showing 3 changed files with 130 additions and 13 deletions.
77 changes: 69 additions & 8 deletions misc/python/materialize/checks/cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@
from typing import List

from materialize.checks.actions import Testdrive
from materialize.checks.checks import CheckDisabled
from materialize.checks.checks import Check
from materialize.util import MzVersion


class CreateCluster(CheckDisabled):
class CreateCluster(Check):
def manipulate(self) -> List[Testdrive]:
return [
Testdrive(dedent(s))
Expand Down Expand Up @@ -62,8 +63,7 @@ def validate(self) -> Testdrive:
)


# https://github.com/MaterializeInc/materialize/issues/13235
class DropCluster(CheckDisabled):
class DropCluster(Check):
def manipulate(self) -> List[Testdrive]:
return [
Testdrive(dedent(s))
Expand Down Expand Up @@ -101,20 +101,81 @@ def validate(self) -> Testdrive:
"""
> SET cluster=drop_cluster1
> SET cluster=create_cluster2
> SET cluster=drop_cluster2
> SET cluster=default
> SELECT * FROM drop_cluster1_table;
123
> SELECT * FROM drop_cluster1_view;
123
! SELECT * FROM drop_cluster1_view;
contains: unknown catalog item 'drop_cluster1_view'
> SELECT * FROM drop_cluster2_table;
234
> SELECT * FROM drop_cluster2_view;
! SELECT * FROM drop_cluster2_view;
contains: unknown catalog item 'drop_cluster2_view'
"""
)
)


class RenameCluster(Check):
def _can_run(self) -> bool:
return self.base_version >= MzVersion.parse("0.57.0-dev")

def manipulate(self) -> List[Testdrive]:
return [
Testdrive(dedent(s))
for s in [
"""
> CREATE TABLE rename_cluster1_table (f1 INTEGER);
> CREATE TABLE rename_cluster2_table (f1 INTEGER);
> INSERT INTO rename_cluster1_table VALUES (123);
> INSERT INTO rename_cluster2_table VALUES (234);
> CREATE CLUSTER rename_cluster1 REPLICAS (replica1 (SIZE '2-2'));
> CREATE CLUSTER rename_cluster2 REPLICAS (replica1 (SIZE '2-2'));
> SET cluster=rename_cluster1
> CREATE DEFAULT INDEX ON rename_cluster1_table;
> CREATE MATERIALIZED VIEW rename_cluster1_view AS SELECT SUM(f1) FROM rename_cluster1_table;
> SET cluster=rename_cluster2
> CREATE DEFAULT INDEX ON rename_cluster2_table;
> CREATE MATERIALIZED VIEW rename_cluster2_view AS SELECT SUM(f1) FROM rename_cluster2_table;
> ALTER CLUSTER rename_cluster1 RENAME TO rename_cluster_new1;
""",
"""
> ALTER CLUSTER rename_cluster2 RENAME TO rename_cluster_new2;
""",
]
]

def validate(self) -> Testdrive:
return Testdrive(
dedent(
"""
> SET cluster=rename_cluster_new1
> SET cluster=rename_cluster_new2
> SET cluster=default
> SELECT * FROM rename_cluster1_table;
123
> SELECT * FROM rename_cluster1_view;
123
> SELECT * FROM rename_cluster2_table;
234
> SELECT * FROM rename_cluster2_view;
234
"""
)
Expand Down
1 change: 1 addition & 0 deletions misc/python/materialize/checks/mzcompose_actions.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ def execute(self, e: Executor) -> None:
"ALTER SYSTEM SET max_materialized_views = 1000;",
"ALTER SYSTEM SET max_objects_per_schema = 1000;",
"ALTER SYSTEM SET max_secrets = 1000;",
"ALTER SYSTEM SET max_clusters = 1000;",
}

if e.current_mz_version >= MzVersion(0, 45, 0):
Expand Down
65 changes: 60 additions & 5 deletions misc/python/materialize/checks/replica.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
from typing import List

from materialize.checks.actions import Testdrive
from materialize.checks.checks import CheckDisabled
from materialize.checks.checks import Check
from materialize.util import MzVersion


# https://github.com/MaterializeInc/materialize/issues/13235
class CreateReplica(CheckDisabled):
class CreateReplica(Check):
def manipulate(self) -> List[Testdrive]:
return [
Testdrive(dedent(s))
Expand Down Expand Up @@ -52,8 +52,7 @@ def validate(self) -> Testdrive:
)


# https://github.com/MaterializeInc/materialize/issues/13235
class DropReplica(CheckDisabled):
class DropReplica(Check):
def manipulate(self) -> List[Testdrive]:
return [
Testdrive(dedent(s))
Expand All @@ -73,10 +72,12 @@ def manipulate(self) -> List[Testdrive]:
> INSERT INTO drop_replica_table VALUES (3);
> CREATE CLUSTER REPLICA drop_replica.replica2 SIZE '2-2';
> INSERT INTO drop_replica_table VALUES (4);
> DROP CLUSTER REPLICA drop_replica.replica1;
""",
"""
> INSERT INTO drop_replica_table VALUES (5);
> DROP CLUSTER REPLICA drop_replica.replica2;
> CREATE CLUSTER REPLICA drop_replica.replica1 SIZE '2-2';
> INSERT INTO drop_replica_table VALUES (6);
""",
]
Expand All @@ -101,3 +102,57 @@ def validate(self) -> Testdrive:
"""
)
)


class RenameReplica(Check):
def _can_run(self) -> bool:
return self.base_version >= MzVersion.parse("0.57.0-dev")

def manipulate(self) -> List[Testdrive]:
return [
Testdrive(dedent(s))
for s in [
"""
> CREATE TABLE rename_replica_table (f1 INTEGER);
> INSERT INTO rename_replica_table VALUES (1);
> CREATE CLUSTER rename_replica REPLICAS ();
> SET cluster=rename_replica
> CREATE DEFAULT INDEX ON rename_replica_table;
> CREATE MATERIALIZED VIEW rename_replica_view AS SELECT COUNT(f1) FROM rename_replica_table;
> INSERT INTO rename_replica_table VALUES (2);
> CREATE CLUSTER REPLICA rename_replica.replica1 SIZE '2-2';
> INSERT INTO rename_replica_table VALUES (3);
> CREATE CLUSTER REPLICA rename_replica.replica2 SIZE '2-2';
> INSERT INTO rename_replica_table VALUES (4);
> ALTER CLUSTER REPLICA rename_replica.replica1 RENAME TO replica_new1
""",
"""
> INSERT INTO rename_replica_table VALUES (5);
> ALTER CLUSTER REPLICA rename_replica.replica2 RENAME TO replica_new2;
> INSERT INTO rename_replica_table VALUES (6);
""",
]
]

def validate(self) -> Testdrive:
return Testdrive(
dedent(
"""
> SET cluster=rename_replica
> SELECT * FROM rename_replica_table;
1
2
3
4
5
6
> SELECT * FROM rename_replica_view;
6
"""
)
)

0 comments on commit 915ea5f

Please sign in to comment.