Deferred webp encoding for faster frame add #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this PR yet. I am going to try modifying it so it doesn't totally block the main thread during compilation. |
|
This works great, but note that there is a breaking change included. The signature of |
antimatter15
added a commit
that referenced
this pull request
Dec 12, 2015
Deferred webp encoding for faster frame add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing image data is much faster than encoding to webp. This PR stores the image data, and waits to encode webp in the compile method.
Here are some test videos from #34
Immediate encoding: https://youtu.be/QK9AOAvGMsw
Delayed encoding: https://youtu.be/99Kob5Xv0Yk