Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak packaging #9

Closed
3 of 4 tasks
gombosg opened this issue Aug 27, 2020 · 11 comments · Fixed by #48
Closed
3 of 4 tasks

Flatpak packaging #9

gombosg opened this issue Aug 27, 2020 · 11 comments · Fixed by #48
Assignees
Labels
packaging Every issue linked with providing and fixing packages for different distributions and systems

Comments

@gombosg
Copy link
Collaborator

gombosg commented Aug 27, 2020

@gombosg gombosg self-assigned this Aug 27, 2020
@gombosg gombosg added the packaging Every issue linked with providing and fixing packages for different distributions and systems label Aug 27, 2020
@gombosg
Copy link
Collaborator Author

gombosg commented Sep 1, 2020

@pktiuk
The flatpak functionally works fine, only the icons are missing in the app. Where are those pulled from?
See https://github.com/AntiMicroX/antimicroX/tree/flatpak
image

@pktiuk
Copy link
Member

pktiuk commented Sep 1, 2020

You can find them here:
src/icons/icons/16x16/actions/16-actions-edit_clear_list.png

@gombosg
Copy link
Collaborator Author

gombosg commented Sep 2, 2020

LOL, icons just loaded after a restart. 🤷‍♂️
EDIT: After a rebuild, they are gone again. Ugh.

@gombosg
Copy link
Collaborator Author

gombosg commented Sep 2, 2020

@pktiuk
I figured out, but not the root cause.
If I touch anything in that icons folder, like create a file, the icons would load from then on. WTF?!
EDIT: It's some icon caching issue.

@pktiuk
Copy link
Member

pktiuk commented Sep 2, 2020

I don't have this issue with icons (I don't have any gamepads with me now, so I checked these icons)
image
image

@gombosg
Copy link
Collaborator Author

gombosg commented Sep 2, 2020

I found out, what you tested already contained the fix. :)
Flatpak sets every file to 0 (1/1/1970) timestamp. The icon cache file contains wrong values. I added a postinstall command to update the icon cache. There is a #flatpak channel on IRC, folks are helpful there! :)

@gombosg
Copy link
Collaborator Author

gombosg commented Sep 14, 2020

Pull

After merging, I'll delete the manifest in this repo, it will be maintained over in Flathub.

@gombosg
Copy link
Collaborator Author

gombosg commented Sep 14, 2020

Gotta fix that build, the icon definition is missing from the appstream XML file. 😏

@gombosg
Copy link
Collaborator Author

gombosg commented Sep 15, 2020

Build fixed, so Flathub people can continue the review.

@pktiuk
Copy link
Member

pktiuk commented Sep 27, 2020

What is the purpose of: https://github.com/flathub/io.github.antimicrox.antimicrox ?
Is it just a simple repository used for maintaining flatpak (do we have to update it after every release?)

@gombosg
Copy link
Collaborator Author

gombosg commented Sep 27, 2020

Yes, the Flathub app is generated from there, we have to update with tag & commit ID with every release. Good reminder to delete the manifest here.

Edit: that's why you should beat their admins until they give you write access to the repo :trollface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Every issue linked with providing and fixing packages for different distributions and systems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants