Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io.github.antimicrox.antimicrox #1828

Closed
wants to merge 7 commits into from
Closed

Add io.github.antimicrox.antimicrox #1828

wants to merge 7 commits into from

Conversation

gombosg
Copy link

@gombosg gombosg commented Sep 14, 2020

Needs --device=all to access various gamepads.
Tested functionality, appears to be working fine.
Needs a gtk-update-icon-cache postinstall to be able and show icons inside the app.

@gombosg gombosg changed the title chore(packaging): initial manifest Add io.github.antimicrox.antimicrox Sep 14, 2020
@gombosg
Copy link
Author

gombosg commented Sep 14, 2020

bot, build io.github.antimicrox.antimicrox

@flathubbot
Copy link

Queued test build for io.github.antimicrox.antimicrox.

@flathubbot
Copy link

Started test build 27483

@gombosg gombosg mentioned this pull request Sep 14, 2020
4 tasks
@flathubbot
Copy link

Build 27483 failed

@gombosg gombosg marked this pull request as draft September 14, 2020 08:05
@gombosg
Copy link
Author

gombosg commented Sep 14, 2020

bot, build io.github.antimicrox.antimicrox

@flathubbot
Copy link

Queued test build for io.github.antimicrox.antimicrox.

@flathubbot
Copy link

Started test build 27484

@flathubbot
Copy link

Build 27484 failed

@gombosg
Copy link
Author

gombosg commented Sep 14, 2020

bot, build io.github.antimicrox.antimicrox

@flathubbot
Copy link

Queued test build for io.github.antimicrox.antimicrox.

@flathubbot
Copy link

Started test build 27485

@flathubbot
Copy link

Build 27485 failed

@@ -0,0 +1,24 @@
app-id: io.github.antimicrox.antimicrox
runtime: org.kde.Platform
runtime-version: '5.11'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for using 5.11?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, what tag do you suggest?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.15 is the latest release.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refreshed to latest, thanks!

@gombosg
Copy link
Author

gombosg commented Sep 14, 2020

Still need to pass AppStream XML validation, by adding icons.

@Nokia808
Copy link

@bilelmoussaoui
Hi. Just one note: this project is already DEAD & it was killed by it's developer ! - see read me at this repository:
https://github.com/juliagoda/antimicroX

So, is it allowed to ship already dead application to FlatHub ?? In one previous issue, I inform you about a software used for Ethreum that is was killed & you remove it from FlatHub (archive it) .......

Kindly, to examine this above .........

@gombosg
Copy link
Author

gombosg commented Sep 14, 2020

@Nokia808 this is a maintained fork at https://github.com/AntiMicroX/antimicrox.

@Nokia808
Copy link

@gombosg
Thank you too much for shipping this to FlatHub ! The diversity of repositories & changing from one to one made me confused ... Please appreciate that I'm not programmer, & for that I used Google to search ...

@gombosg
Copy link
Author

gombosg commented Sep 15, 2020

bot, build io.github.antimicrox.antimicrox

@flathubbot
Copy link

Queued test build for io.github.antimicrox.antimicrox.

@flathubbot
Copy link

Started test build 27581

@flathubbot
Copy link

Build 27581 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/26547/io.github.antimicrox.antimicrox.flatpakref

@gombosg gombosg marked this pull request as ready for review September 15, 2020 11:46
@gombosg
Copy link
Author

gombosg commented Sep 15, 2020

Build succeeded, so I reopened.

@gombosg
Copy link
Author

gombosg commented Sep 15, 2020

bot, build io.github.antimicrox.antimicrox

@flathubbot
Copy link

Queued test build for io.github.antimicrox.antimicrox.

@flathubbot
Copy link

Started test build 27583

@flathubbot
Copy link

Build 27583 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/26549/io.github.antimicrox.antimicrox.flatpakref

@gombosg
Copy link
Author

gombosg commented Sep 16, 2020

@bilelmoussaoui ready for another review pass. Thanks!

# X11 + XShm access
- --share=ipc
- --socket=x11
- --device=dri
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already have device=dri with device=all

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed!

@bilelmoussaoui
Copy link
Member

Anyone else from upstream that would like write access to the repository once created?

@gombosg
Copy link
Author

gombosg commented Sep 17, 2020

@bilelmoussaoui please also add the other maintainer @pktiuk.
Edit: and/or the org AntiMicroX if that's an option.

@bilelmoussaoui
Copy link
Member

The bot we use can't add a whole org yet, see #1678

@nedrichards
Copy link
Member

bot, build io.github.antimicrox.antimicrox

@flathubbot
Copy link

Queued test build for io.github.antimicrox.antimicrox.

@flathubbot
Copy link

Started test build 27918

@flathubbot
Copy link

Build 27918 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/26877/io.github.antimicrox.antimicrox.flatpakref

@gombosg
Copy link
Author

gombosg commented Sep 22, 2020

@bilelmoussaoui when is the repo planned to be created?

@nedrichards
Copy link
Member

/merge @pktiuk.

@gombosg
Copy link
Author

gombosg commented Sep 27, 2020

Great, thanks!

@bilelmoussaoui
Copy link
Member

/merge @pktiuk

@pktiuk
Copy link

pktiuk commented Sep 27, 2020

@bilelmoussaoui @nedrichards

/merge @pktiuk

Sorry, I don't know what you want me to do.
I am not able to merge it, because I have no rights to this repository.

@bilelmoussaoui
Copy link
Member

It's a bot that's supposed to merge it, not sure why it's not working.

@barthalion
Copy link
Member

/merge @pktiuk

@flathubbot
Copy link

A repository for this has been created: https://github.com/flathub/io.github.antimicrox.antimicrox

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Sep 28, 2020
@barthalion
Copy link
Member

So looks like the repository has been created before but the pull request not closed. I will try to make the action more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants