Bug fix when the prompt contains ESC chars #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refreshSingleLine would use strlen to count the number of "forward" operations to send to the cursor. This causes the cursor to move too far off if the prompt contains ANSI color codes. Example: "\x1b[1mHello> \x1b[0m" contains 15 characters, but only 7 on rendered on the terminal, so refreshSingleLine would move the cursor forward too much. The function strlenPerceived counts the number of non escaped characters which appears to fix this bug.
SquidDev
added a commit
to SquidDev/urn
that referenced
this pull request
Aug 9, 2017
This prevents accessing history being slightly odd in readline based inputs. As antirez/linenoise#135 hasn't been merged, linenoise will break on coloured inputs - sadly there isn't much we can do about that, so let's strip them.
|
Merged rain-1@0e3cf08 |
apainintheneck
added a commit
to apainintheneck/crystal-linenoise
that referenced
this pull request
Feb 6, 2024
The cursor based its offset on the literal length of the line not the visual length of the line which caused problems when using escape codes. This fix was pulled in from an upstream branch and it fixes the calculation for the cursor. Note: This bug is still present in the multiline version though. - antirez/linenoise#135 - https://github.com/olegat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refreshSingleLine would use strlen to count the number of
"forward" operations to send to the cursor. This causes the
cursor to move too far off if the prompt contains ANSI
color codes. Example:
"\x1b[1mHello> \x1b[0m" contains 15 characters, but only 7
on rendered on the terminal, so refreshSingleLine would
move the cursor forward too much.
The function strlenPerceived counts the number of non
escaped characters which appears to fix this bug.