Sentinel info returns nothing for "all" #1915
Comments
mattsta
added a commit
to mattsta/redis
that referenced
this issue
Aug 6, 2014
Improvements: - Return error if asking for bad section (INFO foo) - Fix potential memory leak (caused by sdsempty() then returned if >2 args) - Clean up argument parsing - Allow "all" as valid section (same as "default" or zero args currently) - Move strcasecmp to end of evaluation chain in conditionals Also, since we're C99, I moved some variable declarations to be closer to where they are actually used (saves us from needing to free an empty info if detect argument errors up front). Closes redis#1915
|
Thanks for the suggestion! I've added "INFO all" along with some other tiny fixes in mattsta@f92f2d2. |
Closed
|
Sweet. Thanks, @mattsta |
mattsta
added a commit
to mattsta/redis
that referenced
this issue
Aug 25, 2014
Improvements: - Return empty string if asking for non-existing section (INFO foo) - Fix potential memory leak (caused by sdsempty() then returned if >2 args) - Clean up argument parsing - Allow "all" as valid section (same as "default" or zero args currently) - Move strcasecmp to end of evaluation chain in conditionals Also, since we're C99, I moved some variable declarations to be closer to where they are actually used (saves us from needing to free an empty info if detect argument errors up front). Closes redis#1915 Closes redis#1956
mattsta
added a commit
to mattsta/redis
that referenced
this issue
Aug 25, 2014
Improvements: - Return empty string if asking for non-existing section (INFO foo) - Fix potential memory leak (caused by sdsempty() then returned if >2 args) - Clean up argument parsing - Allow "all" as valid section (same as "default" or zero args currently) - Move strcasecmp to end of evaluation chain in conditionals Also, since we're C99, I moved some variable declarations to be closer to where they are actually used (saves us from needing to free an empty info if detect argument errors up front). Closes redis#1915 Closes redis#1956
mattsta
added a commit
to mattsta/redis
that referenced
this issue
Aug 25, 2014
Improvements: - Return empty string if asking for non-existing section (INFO foo) - Fix potential memory leak (caused by sdsempty() then returned if >2 args) - Clean up argument parsing - Allow "all" as valid section (same as "default" or zero args currently) - Move strcasecmp to end of evaluation chain in conditionals Also, since we're C99, I moved some variable declarations to be closer to where they are actually used (saves us from needing to free an empty info if detect argument errors up front). Closes redis#1915 Closes redis#1966
mattsta
added a commit
to mattsta/redis
that referenced
this issue
Dec 11, 2014
Improvements: - Return empty string if asking for non-existing section (INFO foo) - Fix potential memory leak (caused by sdsempty() then returned if >2 args) - Clean up argument parsing - Allow "all" as valid section (same as "default" or zero args currently) - Move strcasecmp to end of evaluation chain in conditionals Also, since we're C99, I moved some variable declarations to be closer to where they are actually used (saves us from needing to free an empty info if detect argument errors up front). Closes redis#1915 Closes redis#1966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As the sentinelInfo command accepts section options such as "sentinel" and "server", it should also support "all" which returns (currently) both of the available sections. This would keep parity with Redis' INFO command and ensure calling code can always call "all" and get the standard section list for that mode rather than nothing.
The text was updated successfully, but these errors were encountered: