Fix redis-trib.rb will fail when migrate a slot with key. #4410
Conversation
The redis-trib.rb call the wrong function which is command client with empty agruments when migrate keys in a slot.
|
@immortal-boy I am still facing this issue after applying this fix. I am using redis-4.0.6 with redis-trib-pass.rb and still facing issue while doing redis-trib-pass.rb reshard [ERR] Calling MIGRATE: ERR Target instance replied with error: NOAUTH Authentication required. I am passing password using auth flag: Command Executed : redis-trib-pass.rb reshard --auth host:ip This error only comes when cluster nodes has keys ...for empty masters ( or for specifically for empty slots) resharding works fine with auth. Any suggestion ? |
|
@immortal-boy Could you provide more details on the issue you're trying to fix with this PR? |
|
@artix75 I use tcpdump catch network packet when using redis-trib.rb to migrate a slot with keys. And I find redis-trib.rb didn't send command MIGRATE but CLIENT, so I find source.r.client isn't a object to client but just call API function "client". |
|
@dineshk8666 I don't see the script redis-trib-pass.rb in tag 4.0.6. Where did you get this script? |
|
@immortal-boy Yes, actually using r.client could be ambiguous. I tried by myself and it worked with me (the r.client method correctly returned the internal ruby object), but i think that it depends on which version of the redis ruby gem is used. |
There was a problem hiding this comment.
hello,@artix75 ,i cant't figure it out.
i add a sub command in add-node ,url https://github.com/marscqy/redis-in-k8s/blob/master/images/redis-trib.rb
it will do reshard after add a node when the new node becoming a master.
i also modify the redis-trib.rb in my pc, #4771 ,and when i using this sub command to add-node ,i will tell me that the cluster is down .
The redis-trib.rb call the wrong function which is command client with empty arguments when migrate keys in a slot.