Diskless-load emptyDb-related fixes #6822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @guybe7, a few notes:
|
1. Call emptyDb even in case of diskless-load: We want modules to get the same FLUSHDB event as disk-based replication. 2. Do not fire any module events when flushing the backups array. 3. Delete redundant call to signalFlushedDb (Called from emptyDb).
guybe7
force-pushed
the
diskless_load_module_hook_fix
branch
from
6e4416b
to
92dc5e1
Compare
|
|
@guybe7 About "2", I get that, I mean right now in my source tree I can't see emptyDb() already calling signalFlushedDb(). But now I see that I mis-understood your comment "Delete redundant call to signalFlushedDb (Called from emptyDb).", You mean that it's already called from emptyDb() so you removed it from the replication code. Perfect, merging, thanks for clarifying. |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Feb 20, 2020
Diskless-load emptyDb-related fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to get the same FLUSHDB event as disk-based replication.