Explicitly set code signing #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not having this set was causing build failures when building with Carthage. Similar to ReactiveCocoa/ReactiveCocoa#2292
|
👍 I think this is correct. |
| @@ -716,6 +718,7 @@ | |||
| isa = XCBuildConfiguration; | |||
| buildSettings = { | |||
| CLANG_ENABLE_MODULES = YES; | |||
| CODE_SIGN_IDENTITY = "iPhone Developer"; | |||
| "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; | |||
There was a problem hiding this comment.
Probably want to delete these though
Missed these on the first pass
|
@neilpa good catch, fixed those. |
|
Seeing as I made the same change for RAC 👍 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having this set was causing intermittent build failures when building with Carthage.
Similar to ReactiveCocoa/ReactiveCocoa#2292
I'm not sure that this is the best solution to this, but I'm not sure it's a bad solution either. If someone has more knowledge behind why this is happening, I'm all ears.