Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift runtime tests run on Windows! #3767

Merged
merged 15 commits into from
Jul 3, 2022
Merged

Conversation

KvanTTT
Copy link
Member

@KvanTTT KvanTTT commented Jun 28, 2022

  • Include Swift runtime tests to CircliCI config
  • Use crossplatform semaphore instead of unsafe raw pthread_mutex_t Make Swift runtime compilable under Windows (yes, it's possible) #3755
  • Fir Swift runtime warnings
  • Fir Swift build directory
  • Unify Swift runtime with others
  • Remove outdated files
  • Simplify and clarity CircleCI scripts
  • NET: 3.1 -> 6.0
  • Minor fixes

@parrt I think it makes sense to disable MacOS agent since it's not reliable and it still doesn't work. I fixed Swift runtime tests and now they work on Linux (CircleCI). Also, Swift runtime tests work on Windows but only from IntelliJ (I haven't found out why they don't work from maven).

Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
@KvanTTT KvanTTT force-pushed the swift-on-windows branch 15 times, most recently from 2c34653 to 9a20e5b Compare July 1, 2022 16:03
Also, it seems faster: https://stackoverflow.com/a/46174300/1046374

Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Add Swift binaries to .gitignore

Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Print exception info to console

Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Fix build warnings

Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
@KvanTTT KvanTTT force-pushed the swift-on-windows branch 5 times, most recently from 46c71fa to 552c71a Compare July 1, 2022 16:37
@parrt
Copy link
Member

parrt commented Jul 1, 2022

Yeah, I'm not sure that github has gotten their Mac support to work very well but @ericvergnaud might have more information since he knows the set up.

@KvanTTT KvanTTT force-pushed the swift-on-windows branch 2 times, most recently from aa00223 to 3bb4415 Compare July 1, 2022 20:09
@KvanTTT KvanTTT marked this pull request as ready for review July 1, 2022 20:16
@KvanTTT
Copy link
Member Author

KvanTTT commented Jul 1, 2022

Now it's ready for review. DCO is failed because I have one commit from another machine, but all CircleCI tests are green, including tests for Swift.

@parrt
Copy link
Member

parrt commented Jul 1, 2022

Ok, I will likely get to this tomorrow as my brain is stuck elsewhere. This will give @ericvergnaud I chance to comment on Mac tests.

@KvanTTT
Copy link
Member Author

KvanTTT commented Jul 1, 2022

Sure, no rush. Anyway, I haven't touched Mac pipelines. It can be removed later.

antlr-exec property is actual for all runtimes, not only Python

Simplify C++ runtime tester (use MSBuild value from PATH for Windows)

Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
@@ -10,5 +8,4 @@ sudo apt-get update; \
sudo apt-get update && \
sudo apt-get install -y dotnet-sdk-3.1
export PATH=$PATH:~/.dotnet
echo "done installing .Net SDK"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably OK, but it looks like this is missing a new line on the end, which annoys UNIX.

@parrt
Copy link
Member

parrt commented Jul 3, 2022

Looks absolutely amazing! Wow Swift on circleci :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants