Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the runtime paths to work in windows #1268

Merged
merged 1 commit into from
Sep 23, 2016
Merged

update the runtime paths to work in windows #1268

merged 1 commit into from
Sep 23, 2016

Conversation

andjo403
Copy link
Contributor

the old paths contained a / at the beginning of the path e.g. "/C:/" but the expected path is "C:/" and due to this all test for the targets javascript, python and c# failed on windows.

the old paths contained a / at the beginning of the path e.g. "/C:/" but the expected path is "C:/" and due to this all test for the targets javascript, python and c# failed on windows.
@BurtHarris
Copy link

I concur: this seems to substantially correct the problem I referred to with large numbers of tests failing on windows.

@BurtHarris
Copy link

Tests run: 620, Failures: 0, Errors: 0, Skipped: 6

[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ antlr4-tool-testsuite ---
[WARNING] JAR will be empty - no content was marked for inclusion!
[INFO] Building jar: C:\code\antlr4\tool-testsuite\target\antlr4-tool-testsuite-4.5.4-SNAPSHOT.jar
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ antlr4-tool-testsuite ---
[INFO] Installing C:\code\antlr4\tool-testsuite\target\antlr4-tool-testsuite-4.5.4-SNAPSHOT.jar to C:\Users\Burt_\.m2\repository\org\antlr\antlr4-tool-testsuite\4.5.4-SNAPSHOT\antlr4-tool-testsuite-4.5.4-SNAPSHOT.jar
[INFO] Installing C:\code\antlr4\tool-testsuite\pom.xml to C:\Users\Burt_\.m2\repository\org\antlr\antlr4-tool-testsuite\4.5.4-SNAPSHOT\antlr4-tool-testsuite-4.5.4-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] ANTLR 4 ............................................ SUCCESS [  0.381 s]
[INFO] ANTLR 4 Runtime .................................... SUCCESS [  5.191 s]
[INFO] ANTLR 4 Tool ....................................... SUCCESS [  1.725 s]
[INFO] ANTLR 4 Maven plugin ............................... SUCCESS [  1.724 s]
[INFO] ANTLR 4 Runtime Test Generator ..................... SUCCESS [08:56 min]
[INFO] ANTLR 4 Tool Tests ................................. SUCCESS [ 16.164 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 09:21 min
[INFO] Finished at: 2016-08-19T14:39:10-07:00
[INFO] Final Memory: 34M/124M
[INFO] ------------------------------------------------------------------------

@BurtHarris
Copy link

BurtHarris commented Sep 23, 2016

@parrt, this corrects an error which blocks testing on Windows. It would be nice to get it merged into master.

@parrt parrt merged commit 5b461dd into antlr:master Sep 23, 2016
@parrt
Copy link
Member

parrt commented Sep 23, 2016

looks good. thanks @andjo403 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants