-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AppVeyor.yml for Windows contious integration #1292
Conversation
@parrt, I think you asked for integration with AppVeyor.com. It was easier than I thought. While I don't understand all the log spew, it seems like a step in the right direction. You'll need to configure an account on AppVeyor.com pointing to the official repository, but that also seems easy. |
Can you try to use |
@KvanTTT, I'm not sure where you are suggesting I would add the I think we want the badge to reflect the builds on the official fork rather than mine, so I don't think I can propose an edit for this until that's set-up. |
build:
verbosity: quiet|minimal|normal|detailed See also an official appveyor.yml reference. Maybe it does not affect result log because here is not a MSBuild system. |
@KvanTTT, adding That seems to be because it's maven & the antlr4 runtime-testsuite are controlling all the output. The integration approach used by runtime-testsuite with the target-speific languages, c# in particular, is generating much of the output by building and running the tests one-at-a-time rather than in a large batch (which would run much faster.) @ericvergnaud seem to know the most about these tests, perhaps he can review confirm: https://ci.appveyor.com/project/BurtHarris/antlr4/build/4.5.4-SNAPSHOT+AppVeyor.21 |
@@ -0,0 +1,9 @@ | |||
version: '4.5.4-SNAPSHOT+AppVeyor.{build}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 This will quickly become incorrect. You can improve on this by moving the version handling to the build script like this. To determine the specific build number for the call to Update-AppveyorBuild
, you can extract it from the pom.xml file.
version: '4.5.4-SNAPSHOT+AppVeyor.{build}' | ||
os: Windows Server 2012 | ||
build_script: | ||
- mvn compile -q --batch-mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharwell, yes, Maven is available in AppVeyor.
- mvn install -q -Dantlr-python2-python="C:\Python27\python.exe" -Dantlr-python3-python="C:\Python35\python.exe" -Dantlr-javascript-nodejs="C:\Program Files (x86)\nodejs\node.exe" --batch-mode | ||
build: | ||
verbosity: minimal | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 I would prefer to see the file end with a trailing newline character
build_script: | ||
- mvn compile -q --batch-mode | ||
test_script: | ||
- mvn install -q -Dantlr-python2-python="C:\Python27\python.exe" -Dantlr-python3-python="C:\Python35\python.exe" -Dantlr-javascript-nodejs="C:\Program Files (x86)\nodejs\node.exe" --batch-mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 I have no experience with the dependencies listed here (w.r.t. AppVeyor). Do you know if they come pre-installed on AppVeyor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All AppVeyor preinstalled tools listed here: Build Worker installed software.
from last line of appvayor.yml
hiya. so does this correctly build antlr on a windows machine? that would be nice. |
Yes, it seems to. The tests say they are passing, but I'd still like an expert to review. |
@BurtHarris How would i know if this stuff works? Do i need to become member of AppVeyor etc...? How can I test? |
@parrt, yes, you should sign up to AppVeyor, link your account with GitHub account, select ANTLR repository and setup build config manually via Web UI or add |
@KvanTTT ok, created account. Will investigate |
I also suggest to add AppVeyor build status on README page. |
added badge. |
This adds a simple configuration file to the root directory which enables use of appveyor.com for Windows-based integration testing. See a sample build from my fork at https://ci.appveyor.com/project/BurtHarris/antlr4