Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -trace to TestRig. fixed code gen issue for trace listener #2

Merged
merged 1 commit into from
Jan 31, 2012

Conversation

parrt
Copy link
Member

@parrt parrt commented Jan 31, 2012

trying my first pull from parrt/antlr4 to antlr/antlr4. Should go from dev to dev.

parrt added a commit that referenced this pull request Jan 31, 2012
added -trace to TestRig. fixed code gen issue for trace listener
@parrt parrt merged commit 433a30c into antlr:master Jan 31, 2012
@anatol
Copy link

anatol commented Jan 31, 2012

Well, you don't have to create a pull request for every your change. You already a project developer and have "push" permission. Pull requests are for contributors.

@parrt
Copy link
Member Author

parrt commented Jan 31, 2012

yeah, just testing / using as you suggested. ;) how do i get a freakin dev branch in antlr/antlr4 btw?
Ter
On Jan 30, 2012, at 5:01 PM, Anatol wrote:

Well, you don't have to create a pull request for every your change. You already a project developer and have "push" permission. Pull requests are for contributors.


Reply to this email directly or view it on GitHub:
#2 (comment)

@anatol
Copy link

anatol commented Jan 31, 2012

Hi

On Mon, Jan 30, 2012 at 5:10 PM, Terence Parr <
reply@reply.github.com

wrote:

yeah, just testing / using as you suggested. ;) how do i get a freakin dev
branch in antlr/antlr4 btw?

cd your_project
git checkout -b foobar

// hack your project
...

// commit your changes
git commit -am "This is a foo change"

// Double-check your commit
git show

// create a new remote branch and set upstream for local one
// set upstream means that next "git pull" it will pull from just-created
branch
git push -u origin HEAD:refs/heads/new_branch

Ter
On Jan 30, 2012, at 5:01 PM, Anatol wrote:

Well, you don't have to create a pull request for every your change. You
already a project developer and have "push" permission. Pull requests are
for contributors.


Reply to this email directly or view it on GitHub:
#2 (comment)


Reply to this email directly or view it on GitHub:
#2 (comment)

@parrt
Copy link
Member Author

parrt commented Jan 31, 2012

hmm…well, i got one easily by checking out antlr/antlr4 quickly.

Now i'm learning about remote vs upstream and my forked stuff. fetch vs pull. ugh.
ter
On Jan 30, 2012, at 5:14 PM, Anatol wrote:

Hi

On Mon, Jan 30, 2012 at 5:10 PM, Terence Parr <
reply@reply.github.com

wrote:

yeah, just testing / using as you suggested. ;) how do i get a freakin dev
branch in antlr/antlr4 btw?

cd your_project
git checkout -b foobar

// hack your project
...

// commit your changes
git commit -am "This is a foo change"

// Double-check your commit
git show

// create a new remote branch and set upstream for local one
// set upstream means that next "git pull" it will pull from just-created
branch
git push -u origin HEAD:refs/heads/new_branch

Ter
On Jan 30, 2012, at 5:01 PM, Anatol wrote:

Well, you don't have to create a pull request for every your change. You
already a project developer and have "push" permission. Pull requests are
for contributors.


Reply to this email directly or view it on GitHub:
#2 (comment)


Reply to this email directly or view it on GitHub:
#2 (comment)


Reply to this email directly or view it on GitHub:
#2 (comment)

@parrt
Copy link
Member Author

parrt commented Jan 31, 2012

Wow. got it all figured out ;) Well, I was quite confused because I was in the wrong directory in one moment, but I think I'm working things out. Did you see my mail about antlr3-main vs main from p4? I want to make sure we have the right directory before we move on and turnoff p4.
Ter

parrt pushed a commit that referenced this pull request Jun 30, 2015
parrt pushed a commit that referenced this pull request Jun 30, 2015
lecode-official added a commit to xied75/antlr4 that referenced this pull request Feb 14, 2017
[dotnet] target: fix travis.yaml once again
@DHager DHager mentioned this pull request Jul 6, 2017
parrt pushed a commit that referenced this pull request Jul 24, 2018
Make C# NuGet package name more visible and add link to the package
parrt pushed a commit that referenced this pull request Dec 25, 2021
@devNamanG devNamanG mentioned this pull request Dec 28, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants