[PHP] Escape dollar sign in target string literal #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
force-pushed
the
escape_target_string_literal_in_php
branch
from
2d3fd88
to
5d3452e
Compare
|
@marcospassos @parrt PR is ready for review 😉 |
|
@parrt LGTM |
|
@adamwojs, we're also looking for contributors to help us make the PHP runtime faster. Please let me know if you're interested in contributing to the project. |
@marcospassos Yes, I'm. In my opinion this project might bring a lot of value for professional PHP ecosystem, so I will be happy to help 😉 |
|
@adamwojs, great! I believe the biggest opportunity right now is to make the PHP target as faster as the other. It involves a log of profiling, trial, and error. PRs are always welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2709.
TODO:
contributors.txt