Fix build to set the release to Java 8 #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Van Gorder <tkvangorder@users.noreply.github.com>
|
I was able to build locally with this change, install it into my maven local and verify things were working when using 4.10.1-SNAPSHOT and running on Java 8. |
|
@parrt if you haven't released yet, you probably want to include this PR in 4.10 |
|
Probably it makes sense of publishig RC (release candidate) before real release. |
|
This seems fine to me. Deferring to @parrt though. |
|
Damn. what if I release with mvn as 4.10.0-1 ? |
|
@KvanTTT @ericvergnaud should i do 4.10-1 or 4.10.1? i suggest 4.10-1 (or 4.10.0-1) with mvn then update jars. don't change version in software. |
|
4.10.1
… Le 14 avr. 2022 à 22:10, Terence Parr ***@***.***> a écrit :
@KvanTTT <https://github.com/KvanTTT> @ericvergnaud <https://github.com/ericvergnaud> should i do 4.10-1 or 4.10.1?
—
Reply to this email directly, view it on GitHub <#3648 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJE2A7OLU4B4Z7RF6BLVFB3S3ANCNFSM5TE2FLHA>.
You are receiving this because you were mentioned.
|
|
oh man. now i gotta go thru release process again. haha. |
|
trust me, I feel your pain. 8) |
parrt
added a commit
that referenced
this pull request
Apr 15, 2022
* [C++] Remove reference to antlrcpp:s2ws (#3656) Signed-off-by: Justin King <jcking@google.com> * Fix build to set the release to Java 8 (#3648) Signed-off-by: Tyler Van Gorder <tkvangorder@users.noreply.github.com> Co-authored-by: Tyler Van Gorder <tkvangorder@users.noreply.github.com> * prep for 4.10.1 Signed-off-by: Terence Parr <parrt@antlr.org> * fix v numbers Signed-off-by: Terence Parr <parrt@antlr.org> Co-authored-by: Justin King <jcking@google.com> Co-authored-by: Tyler Van Gorder <1878529+tkvangorder@users.noreply.github.com> Co-authored-by: Tyler Van Gorder <tkvangorder@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 4.10.0 runtime of antlr correctly sets the
sourceandtargetto 1.8, however, the compiler is still compiling against the Java 11 runtime classpath. This results in the runtime using a different method signature forjava.nio.CharBuffer.flip()This manifests as the following error when using antlr in a java8-based project:
This PR sets the release (used by the maven compiler plugin) to 8, thus forcing it to use the java 8 runtime when compiling.