Don't make class SementicContext::Empty final. #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @KvanTTT |
The class does not implement the pure virtual methods so can not be considered 'final'. Clang 10 and 11 complain about this. Context: chipsalliance/Surelog#3081 Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
20220706-dont-make-incomplete-virtual-class-final
branch
from
5e35490
to
2fd7146
Compare
|
The MacOSX CI issues seem to be unrelated (It fails attempting to download something) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't make class SementicContext::Empty final.
The class does not implement the pure virtual methods so can
not be considered 'final'. Clang 10 and 11 complain about this.
Context: chipsalliance/Surelog#3081