Report all "mutually left recursive rules" errors and fix positions #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KvanTTT
changed the title
KvanTTT
force-pushed
the
correct-position-for-mutually-left-recursive-rules-error
branch
from
6799c2b
to
f49d563
Compare
|
@parrt It can be reviewed and merged |
KvanTTT
force-pushed
the
correct-position-for-mutually-left-recursive-rules-error
branch
2 times, most recently
from
7a0c92d
to
aeff691
Compare
KvanTTT
force-pushed
the
correct-position-for-mutually-left-recursive-rules-error
branch
from
aeff691
to
5c09902
Compare
|
@parrt it's ready for merge. |
|
Hi @KvanTTT I don't have the time to read through this at the moment I'm afraid. I will only have time to try a release for @ericvergnaud tomorrow. Swamped at work and working fiendishly on my dtreeviz lib at the moment :( |
|
@parrt any chance it will be reviewed and merged this time? |
All fields of ANTLRMessage are final Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Throw LEFT_RECURSION_CYCLES for every erroneous rule instead of the first one Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
KvanTTT
force-pushed
the
correct-position-for-mutually-left-recursive-rules-error
branch
from
5c09902
to
25d0982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes antlr/antlr5#34