fix: #3758 Allow for string being a keyword and fix go template to us… #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e escapedName
- The go template was ignoring the use of escapedName in many places and was
not consistenet with the Java version.
- Added 'string' to the list of reserved words for the Go target
Signed-off-by: Jim.Idle <jimi@gatherstars.com>
|
Could you please add a test that covers the case? |
added 2 commits
August 23, 2022 10:25
Signed-off-by: Jim.Idle <jimi@gatherstars.com>
….mod Signed-off-by: Jim.Idle <jimi@gatherstars.com>
|
The go.mod file is updated to include the go runtime extensions and the go.sum file is added to the repo, which I had not noticed was missing. |
parrt
reviewed
Aug 23, 2022
|
I will add a string rule to the existing keyword test. I should have done that with this PR. |
|
@parrt I thin we can close this now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3758 Consistently apply
.escapedNameinstead of just.namefor the go target. Addstringto reserved wordsescapedName, hence it would generate rules and so onthat were keywords in go.
stringas a keyword for go