Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TypeScript runtime tests performance #4286

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

KvanTTT
Copy link
Member

@KvanTTT KvanTTT commented May 26, 2023

Use symbolic linking for node_modules.

Get rid of extra copying

fixed antlr#4229

Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
@KvanTTT KvanTTT marked this pull request as ready for review May 26, 2023 18:17
@KvanTTT
Copy link
Member Author

KvanTTT commented May 26, 2023

@ericvergnaud @parrt all tests are green, it's ready for review.

@KvanTTT KvanTTT marked this pull request as draft May 26, 2023 18:37
@KvanTTT
Copy link
Member Author

KvanTTT commented May 26, 2023

I'll try to optimize one more thing.

@ericvergnaud
Copy link
Contributor

Hey
Great if the copy directory is faster than npm install
Not sure however how renaming things improves performance ?
More importantly I think that having version numbers in the steps names is useful. You see at first glance what environment you are testing against

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants