Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portable-45 project that targets Portable Profile 259 #41

Closed
wants to merge 4 commits into from

Conversation

jeremymeng
Copy link

This fixes #40.

@sharwell
Copy link
Member

sharwell commented Nov 7, 2015

In general I like the idea, but I have a number of specific concerns. Do you have any objection to me submitting an alternate pull request to address the same problem, in order to keep the resulting new code a bit closer to the code used by the other project files?

@@ -0,0 +1,238 @@

Microsoft Visual Studio Solution File, Format Version 12.00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 I would prefer to not add a new solution file, since it would confuse new contributors regarding which one they should be working in.

@jeremymeng
Copy link
Author

Do you have any objection to me submitting an alternate pull request to address the same problem, in order to keep the resulting new code a bit closer to the code used by the other project files?

Definitely no. It would be better if you are adding the support since no one knows the code better than you do.

@jeremymeng
Copy link
Author

Closing as @sharwell will submit an alternative pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support portable-net45
2 participants