-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue 2390--Add JavaScript testing. #2392
Conversation
… an "invert" run of the skip list (test all in the skip list); (2) Add JavaScript back to GitHub main.yml; (3) Remove selected skipped grammars, as they now work; (4) Update the test.sh script for testing JavaScript parsers, cut off excessive output for parsers like sql/plsql which output way too much. (5) Add "skp-javascript.why" to indicate why certain grammars are in the skip-javascript.txt "skip list". #2390
@studentmain Good idea. I will try to do that. Not exactly sure why regtest.sh is running cleanly on my machine, while test.ps1 here in GitHub Actions is reporting errors. Oh yes, it definitely looks like the skip list isn't being handled consistently between regtest.sh and test.ps1. This must be fix--I will investigate. |
The difference in what is reported as an error in the build between regtest.sh and test.ps1 is caused by a simple difference in interpretation of the results of trgen. regtest.sh considers a grammar as "failed" if trgen returns the name in stderr; test.ps1 considers a grammar as "failed" if trgen didn't actually generate a "Generated/" directory. In some of the grammars, the pom.xml has not the usual two plug-in specifications (one for running the Antlr4 tool on the grammar(s), the other for running the generated parser on input files), but just one--only test whether the Antlr4 tool compiles the grammar cleanly. When there isn't the test plug-in spec in the pom.xml, trgen doesn't know what the grammar is, what the start symbol is for the grammar. Without that information, it doesn't know what to do and doesn't generate anything at all. What should happen is to at least generate a makefile that runs the Antlr4 tool. For now, I will add in these grammars to the skip list. In case when trgen really fails on the pom, do not generate partially filled Generated/ directories. I am planning to update the build with the latest trgen, but after I fix this build. |
…to output the version of nodejs. Update specific "engine" version after this change.
…uts to stdout, nothing outputed. Update main.yml to install s apecific version for nodejs. I use 16.13.0 on Ubuntu and it works.
All set. Javascript testing is back. |
@kaby76 thanks |
This PR adds JavaScript testing back into the CI GitHub Actions build.
ErrorCaptureStackTrace(err) undefined
, (d) stack overflow, (e) doesn't contain a functioning grammar, or incomplete.