Support all privileges of MariaDB 10.6 in MariaDB grammar #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KvanTTT
requested changes
Feb 13, 2023
There was a problem hiding this comment.
We already have separated grammar for MariaDB: https://github.com/antlr/grammars-v4/tree/master/sql/mariadb
@uurl could you check if it's correct to add MariaDB changes to the current grammar? Or they should be added to the separated grammar.
KvanTTT
added
example
joschi
force-pushed
the
mariadb-privileges
branch
from
04eb4e5
to
ae53be5
Compare
@KvanTTT Yes, I saw that and updated this MR. 😄 |
joschi
force-pushed
the
mariadb-privileges
branch
from
ae53be5
to
00bb66d
Compare
joschi
changed the title
KvanTTT
approved these changes
Feb 13, 2023
joschi
added a commit
to joschi/debezium
that referenced
this pull request
Apr 5, 2023
joschi
added a commit
to joschi/debezium
that referenced
this pull request
Apr 5, 2023
jpechane
pushed a commit
to joschi/debezium
that referenced
this pull request
Apr 13, 2023
jpechane
pushed a commit
to debezium/debezium
that referenced
this pull request
Apr 13, 2023
roldanbob
pushed a commit
to roldanbob/debezium
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some privileges supported by MariaDB are missing from the grammar.
This change set adds the missing tokens and tests them against a
GRANTquery with all privileges supported by MariaDB 10.6.x: https://mariadb.com/docs/server/ref/es10.6/privileges/