Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix for #3403 -- Add static type checking of grammars: useless parentheses. #3498

Merged
merged 6 commits into from
Jun 11, 2023
Merged

Conversation

kaby76
Copy link
Contributor

@kaby76 kaby76 commented Jun 1, 2023

This PR is a fix for #3403.

Code is added here to check for useless parentheses. It only provides information that could be valuable in cleaning up a grammar on a case-by-case basis. This code does not raise errors.

The results are contained in the new "static-checks" CI task. An example is here.

@kaby76
Copy link
Contributor Author

kaby76 commented Jun 2, 2023

@kaby76 kaby76 changed the title [build] Fix for #3403 -- Useless parentheses in grammars. [build] Fix for #3403 -- Add lint-like checking of grammars: useless parentheses. Jun 2, 2023
@kaby76 kaby76 changed the title [build] Fix for #3403 -- Add lint-like checking of grammars: useless parentheses. [build] Fix for #3403 -- Add static type checking of grammars: useless parentheses. Jun 3, 2023
@kaby76 kaby76 marked this pull request as ready for review June 11, 2023 00:37
@kaby76
Copy link
Contributor Author

kaby76 commented Jun 11, 2023

This is ready to merge. The checks are in a new task in the build, "static-checks".

@teverett
Copy link
Member

@kaby76 thanks!

@teverett teverett merged commit 354f608 into antlr:master Jun 11, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants