Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting improvements #29

Merged
merged 4 commits into from
Jun 30, 2020
Merged

Highlighting improvements #29

merged 4 commits into from
Jun 30, 2020

Conversation

bjansen
Copy link
Collaborator

@bjansen bjansen commented Jun 29, 2020

  • Added support for template data languages, to highlight text parts around ST tags
  • Added semantic highlighting for ST templates
  • Configured language injection to highlight templates in calls to ST(...), STGroup.defineTemplate() etc

@parrt
Copy link
Member

parrt commented Jun 29, 2020

wow!

@bjansen bjansen merged commit bb09980 into master Jun 30, 2020
@bjansen bjansen deleted the template-data-language branch June 30, 2020 07:35
@Clashsoft
Copy link

There's still a minor issue with this (in the snapshot from #31 (comment)). It seems to have a problem with escaped delimiters.

Screenshot 2020-09-15 at 00 43 14

Btw, can you add this and #30 to the v0.9 milestone, so it's easier to find?

@bjansen bjansen added this to the 0.9 milestone Sep 15, 2020
@bjansen
Copy link
Collaborator Author

bjansen commented Sep 15, 2020

OK, thanks for reporting the problem.

@bjansen bjansen mentioned this pull request Sep 15, 2020
Open
@bjansen bjansen mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjansen @parrt @Clashsoft