Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading templates in containers #207

Merged
merged 2 commits into from Nov 6, 2018
Merged

Conversation

drealeed
Copy link
Contributor

@drealeed drealeed commented Oct 31, 2018

To facilitate getting this in I applied the patch attached to issue #191 and put in a pull request for it.

I also built the jar and tested it with our external products; the patch fixed the issues without introducing others.

Fixes #191

@drealeed drealeed changed the title Issue 191 classloader Loading templates in containers Oct 31, 2018
@parrt
Copy link
Member

parrt commented Nov 6, 2018

@drealeed is this similar to #199 ?

@parrt
Copy link
Member

parrt commented Nov 6, 2018

@drealeed
Copy link
Contributor Author

drealeed commented Nov 6, 2018

Done: #208

@parrt parrt merged commit bc83832 into antlr:master Nov 6, 2018
@parrt parrt added this to the 4.0.9 milestone Nov 6, 2018
@parrt
Copy link
Member

parrt commented Nov 6, 2018

Passed all tests.

@drealeed
Copy link
Contributor Author

drealeed commented Nov 7, 2018

Thanks very much for pulling this. Will there be a snapshot/rc build deployed out to mvnrepository or another repo?

@parrt
Copy link
Member

parrt commented Nov 7, 2018

I'll try to do that this weekend.

@dabayliss
Copy link

Thank you @parrt - I have a team of two dozen people drilling st4/antlr - if we had failed at the deployment step I'd have had egg running down both sides of my face ....

@parrt
Copy link
Member

parrt commented Nov 7, 2018

is there an antlr4 PR too you need?

@parrt
Copy link
Member

parrt commented Nov 7, 2018

Please try 4.0.9-SNAPSHOT via maven or pull down and try from here. seems to work for me on my projects.

@drealeed
Copy link
Contributor Author

drealeed commented Nov 8, 2018

Thanks! We also include antlr and antlr runtime. When testing my fix locally I had to manually exclude stringtemplate from those two projects' maven dependencies, for my local stringtemplate 4.0.9-SNAPSHOT to be picked up rather than the stringtemplate included with antlr. Can those also be recompiled?

@parrt
Copy link
Member

parrt commented Nov 8, 2018

(Changed name to 4.1 from 4.0.9). Added some more stuff. Will test with antlr again.

@parrt
Copy link
Member

parrt commented Nov 10, 2018

@drealeed released 4.1!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import fails when template group is loaded using a container classloader
3 participants