New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading templates in containers #207
Conversation
Done: #208 |
Passed all tests. |
Thanks very much for pulling this. Will there be a snapshot/rc build deployed out to mvnrepository or another repo? |
I'll try to do that this weekend. |
Thank you @parrt - I have a team of two dozen people drilling st4/antlr - if we had failed at the deployment step I'd have had egg running down both sides of my face .... |
is there an antlr4 PR too you need? |
Please try 4.0.9-SNAPSHOT via maven or pull down and try from here. seems to work for me on my projects. |
Thanks! We also include antlr and antlr runtime. When testing my fix locally I had to manually exclude stringtemplate from those two projects' maven dependencies, for my local stringtemplate 4.0.9-SNAPSHOT to be picked up rather than the stringtemplate included with antlr. Can those also be recompiled? |
(Changed name to 4.1 from 4.0.9). Added some more stuff. Will test with antlr again. |
@drealeed released 4.1!!! |
To facilitate getting this in I applied the patch attached to issue #191 and put in a pull request for it.
I also built the jar and tested it with our external products; the patch fixed the issues without introducing others.
Fixes #191