loadGroupURL to STGroup and URL constructor to STGroupFile #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes necessary to support classpath resources in a variety of different deployment scenarios See Antlr4 PR: antlr/antlr4#2280
solussd
added a commit
to solussd/antlr4
that referenced
this pull request
Apr 24, 2018
- absolute file paths not reliable way to find resources on classpath - requires changes to ST4 in this PR: antlr/stringtemplate4#199
|
Hi. Looks pretty good. Have you run it on all the tests in ST? Could you sign this doc? https://github.com/antlr/stringtemplate4/blob/master/contributors.txt thanks |
|
@solussd can you sign the contributor's license so I can merge? thanks! |
|
Closing as fixed in #207 |
|
Hey, sorry– missed the contributors txt. #207 fixes the issue in a different way. I'm not sure it's sufficient for the use case I was fixing (AWS Lambda deployment). |
|
Ok, @solussd, can you try it out? It's in master now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
different deployment scenarios
See Antlr4 PR: antlr/antlr4#2280