Fixed tmpdir variable, for pull request #103 #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I didn't noticed this is a duplicate, and discussed on pull request #91. |
Merged
|
Somehow this issue got backlogged and we never came back to fix it. 😦 I expanded on the issue described here to not only ensure the temporary test output folder is valid, but to also relocated it so Can you take a look at #105 and let me know if it meets all your needs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change to ensure tmpdir ends up with a slash (for Unix systems), or backslash (for Windows), so the tests generating temporary files do not fail due to "cannot write file" errors.