New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix signature of STGroup.getAttributeRenderer #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 With three changes, we can avoid the need to suppress warnings here
@sharwell I think in this case just suppressing the warnings is better than adding the |
The call to I would prefer to use the stronger typing in the absence of proof of a problem (demonstrated performance problem via benchmarks). |
Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
Thanks guys! |
This amends #233 with a minor change to the signature of
STGroup#getAttributeRenderer
, as requested by @sharwell.