Fix issues #276 and #293 by checking for double slashes in STGroupDir #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 24, 2022 10:35
…arning about malformed project.
Mooninaut
changed the title
Remove now-unneeded TestGroupDirPathsGroupFile.stg and references to test-resources in build files.
Mooninaut
force-pushed
the
issue-293-double-slash
branch
2 times, most recently
from
bc3804f
to
8d576be
Compare
Use stripRight in trimOneTrailingNewline. Remove redundant variable in getPrefix. Use fixed string replace in replaceEscapes, no need for regex.
Mooninaut
force-pushed
the
issue-293-double-slash
branch
from
8d576be
to
6e7cff1
Compare
|
Hi! @Mooninaut Thanks!I am back to looking at this issue... I have like five open source projects to maintain at the moment. ugh. Anyway, I still think there must be a standard way to join these. I've just pushed a change that requires java 7 so hopefully there's a method in there. I'll go look now. I'll look at https://github.com/Mooninaut/stringtemplate4/tree/java1.7 |
|
Hi. I'm closing this in favor of the patched just did. Added a bunch of unit tests as well. Can you give it a shot? I just pushed a new snapshot of 4.3.2 via maven. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276 and fixes #293 by adding or trimming a trailing slash to/from the root and a leading slash to/from the parent before constructing the groupFileURL in STGroupDir.java
Adds unit tests to ensure all 4 combinations of root and parent with or without slash work correctly.
NOTE: This does not remove multiple consecutive leading or trailing slashes like
root//or//parent. I feel like supplying such a path counts as user error and is unlikely to occur in practice. If it ever does cause a problem, another issue should be filed.