refactor: seperate zxcvbn dependencies #628
Conversation
zxcvbn implementation of IPasswordStrengthMeterService moved to second entrypoint in order to remove including zxcvbn modules into final bundle when client has custom implementation of IPasswordStrengthMeterService.
projects/password-strength-meter/src/lib/password-strength-meter.component.ts
Outdated
Show resolved
Hide resolved
projects/password-strength-meter-showcase/src/app/custom-psm-service.service.ts
Show resolved
Hide resolved
|
Hi @antoantonyk |
|
Would be nice to see this merged. |
| "@zxcvbn-ts/core": "^2.2.1", | ||
| "@zxcvbn-ts/language-en": "^2.1.0", |
There was a problem hiding this comment.
@HosseinSalmanian sorry for taking this much time. but I am able to work on this week to get this change merged and published.
Could you please explain how to install the lib dependencies while developing?
Looking at this, are we going to install the lib dependencies in their corresponding folder?
Previously I had a copy of dependencies here in the root as well. So it will just compile by doing an installation in the root. But I always had a feeling it is not the best way to do it.
So, just to understand the current local build setup, are the following steps correct?
- npm install (root folder)
- cd /projects/password-strength-meter
- npm install (lib folder)
- npm run build:lib
- npm run serve
I did a quick search, I am not sure which one is the proper solution, I mean
Keep a duplicate/copy lib dependencies in root package.json or install everything individually.
There was a problem hiding this comment.
or do we need to use npm link?
There was a problem hiding this comment.
some details -angular/angular#43058
zxcvbn implementation of IPasswordStrengthMeterService moved to second entrypoint in order to remove including zxcvbn modules into final bundle when client has custom implementation of IPasswordStrengthMeterService.
#223