Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lodash vulnerability #138

Conversation

pedrolamas
Copy link
Contributor

Summary

This solves a known high security vulnerability caused by lodash.set.

Fixes #137

Implementation

Replaces all lodash.* dependencies with lodash-es that allows for easy tree-shaking.

Testing

  • Unit tests were added to cover the new feature or bug fix (+ eventually integration tests)

Impacted documentation

  • Changesets were generated using pnpm changeset at the root of the workspace, affected packages are being bumped (either patch/minor) and a clear description for each of the affected packages was added.

@antoine-coulon antoine-coulon merged commit 4a3bd27 into antoine-coulon:main Jan 30, 2024
6 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/fix-lodash-vulnerability branch January 30, 2024 18:04
@github-actions github-actions bot mentioned this pull request Jan 30, 2024
@antoine-coulon
Copy link
Owner

Thanks for solving that issue with such a quick fix @pedrolamas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs-tree-structure is using a lodash.set that has high severity vulnerability!
2 participants