ci(unit-tests): remove unnecessary docker step and bump node version …

…to 20 (#169)
antoinezanardi · May 15, 2023 · 97df00b · 97df00b
1 parent bb94ad9
commit 97df00b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 15 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -14,7 +14,7 @@ jobs:
     steps:
       - name: Checkout GitHub repository 📡
         uses: actions/checkout@v3
-      - name: Setup NodeJS v18 ⚙️
+      - name: Setup NodeJS v20 ⚙️
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
@@ -36,7 +36,7 @@ jobs:
     steps:
       - name: Checkout GitHub repository 📡
         uses: actions/checkout@v3
-      - name: Setup NodeJS v18 ⚙️
+      - name: Setup NodeJS v20 ⚙️
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
@@ -57,7 +57,7 @@ jobs:
     steps:
       - name: Checkout GitHub repository 📡
         uses: actions/checkout@v3
-      - name: Setup NodeJS v18 ⚙️
+      - name: Setup NodeJS v20 ⚙️
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
@@ -78,7 +78,7 @@ jobs:
     steps:
       - name: Checkout GitHub repository 📡
         uses: actions/checkout@v3
-      - name: Setup NodeJS v18 ⚙️
+      - name: Setup NodeJS v20 ⚙️
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
@@ -89,12 +89,8 @@ jobs:
         with:
           path: node_modules
           key: ${{ runner.os }}-npm-v3-${{ hashFiles('package-lock.json') }}
-      - name: Start Docker containers 🐳
-        run: npm run docker:test:start
       - name: Unit tests 🧪
         run: npm run test:unit:cov
-      - name: Stop Docker containers 🐳
-        run: npm run docker:test:stop
   e2e-tests:
     name: E2E Tests ⚗️
     runs-on: ubuntu-latest
@@ -103,7 +99,7 @@ jobs:
     steps:
       - name: Checkout GitHub repository 📡
         uses: actions/checkout@v3
-      - name: Setup NodeJS v18 ⚙️
+      - name: Setup NodeJS v20 ⚙️
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
@@ -128,7 +124,7 @@ jobs:
     steps:
       - name: Checkout GitHub repository 📡
         uses: actions/checkout@v3
-      - name: Setup NodeJS v18 ⚙️
+      - name: Setup NodeJS v20 ⚙️
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
@@ -159,7 +155,7 @@ jobs:
     steps:
       - name: Checkout GitHub repository 📡
         uses: actions/checkout@v3
-      - name: Setup NodeJS v18 ⚙️
+      - name: Setup NodeJS v20 ⚙️
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -15,7 +15,7 @@ jobs:
     steps:
       - name: Checkout GitHub repository 📡
         uses: actions/checkout@v3
-      - name: Setup NodeJS v18 ⚙️
+      - name: Setup NodeJS v20 ⚙️
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
@@ -39,7 +39,7 @@ jobs:
         uses: actions/checkout@v3
         with:
           persist-credentials: false
-      - name: Setup NodeJS v18 ⚙️
+      - name: Setup NodeJS v20 ⚙️
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
@@ -60,7 +60,7 @@ jobs:
     steps:
       - name: Checkout GitHub repository 📡
         uses: actions/checkout@v3
-      - name: Setup NodeJS v18 ⚙️
+      - name: Setup NodeJS v20 ⚙️
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-18
+20