feat(game-options): thief chosen card revealed option (#713)

Closes #705
antoinezanardi · Dec 3, 2023 · f3277db · f3277db
1 parent 38aa021
commit f3277db
Show file tree

Hide file tree

Showing 8 changed files with 21,769 additions and 21,702 deletions.
diff --git a/src/modules/game/constants/game-options/game-options.constant.ts b/src/modules/game/constants/game-options/game-options.constant.ts
@@ -43,6 +43,7 @@ const DEFAULT_GAME_OPTIONS: ReadonlyDeep<GameOptions> = {
     },
     thief: {
       mustChooseBetweenWerewolves: true,
+      isChosenCardRevealed: false,
       additionalCardsCount: 2,
     },
     piedPiper: {

diff --git a/...reate-game/create-game-options/create-roles-game-options/create-thief-game-options.dto.ts b/...reate-game/create-game-options/create-roles-game-options/create-thief-game-options.dto.ts
@@ -13,6 +13,14 @@ class CreateThiefGameOptionsDto {
   @IsBoolean()
   public mustChooseBetweenWerewolves: boolean = THIEF_GAME_OPTIONS_FIELDS_SPECS.mustChooseBetweenWerewolves.default;
 
+  @ApiProperty({
+    ...THIEF_GAME_OPTIONS_API_PROPERTIES.isChosenCardRevealed,
+    required: false,
+  } as ApiPropertyOptions)
+  @IsOptional()
+  @IsBoolean()
+  public isChosenCardRevealed: boolean = THIEF_GAME_OPTIONS_FIELDS_SPECS.isChosenCardRevealed.default;
+
   @ApiProperty({
     ...THIEF_GAME_OPTIONS_API_PROPERTIES.additionalCardsCount,
     required: false,

diff --git a/.../game-options/roles-game-options/thief-game-options/thief-game-options.schema.constant.ts b/.../game-options/roles-game-options/thief-game-options/thief-game-options.schema.constant.ts
@@ -12,6 +12,10 @@ const THIEF_GAME_OPTIONS_FIELDS_SPECS = {
     required: true,
     default: DEFAULT_GAME_OPTIONS.roles.thief.mustChooseBetweenWerewolves,
   },
+  isChosenCardRevealed: {
+    required: true,
+    default: DEFAULT_GAME_OPTIONS.roles.thief.isChosenCardRevealed,
+  },
   additionalCardsCount: {
     required: true,
     default: DEFAULT_GAME_OPTIONS.roles.thief.additionalCardsCount,
@@ -25,6 +29,10 @@ const THIEF_GAME_OPTIONS_API_PROPERTIES: ReadonlyDeep<Record<keyof ThiefGameOpti
     description: "If set to `true`, if all `thief` additional cards are from the `werewolves` side, he can't skip and must choose one",
     ...convertMongoosePropOptionsToApiPropertyOptions(THIEF_GAME_OPTIONS_FIELDS_SPECS.mustChooseBetweenWerewolves),
   },
+  isChosenCardRevealed: {
+    description: "If set to `true`, the `thief` chosen card is revealed to every other players",
+    ...convertMongoosePropOptionsToApiPropertyOptions(THIEF_GAME_OPTIONS_FIELDS_SPECS.isChosenCardRevealed),
+  },
   additionalCardsCount: {
     description: "Number of additional cards for the `thief` at the beginning of the game",
     ...convertMongoosePropOptionsToApiPropertyOptions(THIEF_GAME_OPTIONS_FIELDS_SPECS.additionalCardsCount),

diff --git a/...e/schemas/game-options/roles-game-options/thief-game-options/thief-game-options.schema.ts b/...e/schemas/game-options/roles-game-options/thief-game-options/thief-game-options.schema.ts
@@ -16,6 +16,11 @@ class ThiefGameOptions {
   @Expose()
   public mustChooseBetweenWerewolves: boolean;
 
+  @ApiProperty(THIEF_GAME_OPTIONS_API_PROPERTIES.isChosenCardRevealed as ApiPropertyOptions)
+  @Prop(THIEF_GAME_OPTIONS_FIELDS_SPECS.isChosenCardRevealed)
+  @Expose()
+  public isChosenCardRevealed: boolean;
+
   @ApiProperty(THIEF_GAME_OPTIONS_API_PROPERTIES.additionalCardsCount as ApiPropertyOptions)
   @Prop(THIEF_GAME_OPTIONS_FIELDS_SPECS.additionalCardsCount)
   @Expose()

diff --git a/tests/e2e/specs/modules/game/controllers/game.controller.e2e-spec.ts b/tests/e2e/specs/modules/game/controllers/game.controller.e2e-spec.ts
@@ -889,6 +889,7 @@ describe("Game Controller", () => {
           },
           thief: {
             mustChooseBetweenWerewolves: false,
+            isChosenCardRevealed: true,
             additionalCardsCount: 4,
           },
           piedPiper: {

diff --git a/...me/create-game-options/create-roles-game-options/create-roles-game-options.dto.factory.ts b/...me/create-game-options/create-roles-game-options/create-roles-game-options.dto.factory.ts
@@ -67,6 +67,7 @@ function createFakeCreatePiedPiperGameOptionsDto(piedPiperGameOptions: Partial<C
 function createFakeCreateThiefGameOptionsDto(thiefGameOptions: Partial<CreateThiefGameOptionsDto> = {}, override: object = {}): CreateThiefGameOptionsDto {
   return plainToInstance(CreateThiefGameOptionsDto, {
     mustChooseBetweenWerewolves: thiefGameOptions.mustChooseBetweenWerewolves ?? faker.datatype.boolean(),
+    isChosenCardRevealed: thiefGameOptions.isChosenCardRevealed ?? faker.datatype.boolean(),
     additionalCardsCount: thiefGameOptions.additionalCardsCount ?? faker.number.int({ min: 1, max: 5 }),
     ...override,
   }, DEFAULT_PLAIN_TO_INSTANCE_OPTIONS);

diff --git a/...ctories/game/schemas/game-options/game-roles-options/game-roles-options.schema.factory.ts b/...ctories/game/schemas/game-options/game-roles-options/game-roles-options.schema.factory.ts
@@ -64,6 +64,7 @@ function createFakePiedPiperGameOptions(piedPiperGameOptions: Partial<PiedPiperG
 function createFakeThiefGameOptions(thiefGameOptions: Partial<ThiefGameOptions> = {}, override: object = {}): ThiefGameOptions {
   return plainToInstance(ThiefGameOptions, {
     mustChooseBetweenWerewolves: thiefGameOptions.mustChooseBetweenWerewolves ?? faker.datatype.boolean(),
+    isChosenCardRevealed: thiefGameOptions.isChosenCardRevealed ?? faker.datatype.boolean(),
     additionalCardsCount: thiefGameOptions.additionalCardsCount ?? faker.number.int({ min: 1, max: 5 }),
     ...override,
   }, DEFAULT_PLAIN_TO_INSTANCE_OPTIONS);