Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean game service and its tests #621

Closed
antoinezanardi opened this issue Oct 30, 2023 · 0 comments
Closed

Clean game service and its tests #621

antoinezanardi opened this issue Oct 30, 2023 · 0 comments
Assignees
@antoinezanardi
Labels
🔩 refactor Code change that neither fixes a bug nor adds a feature

Comments

@antoinezanardi
Copy link
Owner

game.service starts to be big and unreadable.

Refactor it with its tests to be more maintainable)
@antoinezanardi antoinezanardi added the 🔩 refactor Code change that neither fixes a bug nor adds a feature label Oct 30, 2023
@antoinezanardi antoinezanardi self-assigned this Oct 30, 2023
@antoinezanardi antoinezanardi mentioned this issue Nov 26, 2023
Merged
antoinezanardi added a commit that referenced this issue Nov 27, 2023
@antoinezanardi
test(global): make tests more consistent, maintenable and readable (#665
415ca6f 
)

Closes #273 #621 #634
antoinezanardi pushed a commit that referenced this issue Nov 27, 2023
@semantic-release-bot
chore(release): 1.23.0 [skip ci]
c10b9a9 
## [1.23.0](v1.22.0...v1.23.0) (2023-11-27)

### 🚀 Features

* **env:** enhance env validation ([#652](#652)) ([d97c74e](d97c74e)), closes [#618](#618)
* **player-death:** new game play for survivors to bury dead bodies ([#645](#645)) ([2cbbbe7](2cbbbe7))

### ✅ Tests

* **global:** make tests more consistent, maintenable and readable ([#665](#665)) ([415ca6f](415ca6f)), closes [#273](#273) [#621](#621) [#634](#634)

### 🧹 Chore

* **deps:** bump mongoose from 8.0.0 to 8.0.1 ([#648](#648)) ([0ae100d](0ae100d))
* **deps:** bump semantic-release from 22.0.7 to 22.0.8 ([#651](#651)) ([f29475b](f29475b))
* **deps:** bump the commitlint group with 2 updates ([#647](#647)) ([10d47c6](10d47c6))
* **deps:** bump the commitlint group with 2 updates ([#659](#659)) ([9b2201c](9b2201c))
* **deps:** bump the eslint group with 1 update ([#655](#655)) ([c1dec30](c1dec30))
* **deps:** bump the nest group with 1 update ([#646](#646)) ([7271470](7271470))
* **deps:** bump the nest group with 5 updates ([#653](#653)) ([9ae0106](9ae0106))
* **deps:** bump the nest group with 5 updates ([#657](#657)) ([11dfb21](11dfb21))
* **deps:** bump the types group with 1 update ([#650](#650)) ([18f0168](18f0168))
* **deps:** bump the types group with 1 update ([#654](#654)) ([28e56fe](28e56fe))
* **deps:** bump the types group with 1 update ([#666](#666)) ([14f56ab](14f56ab))
* **deps:** bump the types group with 2 updates ([#664](#664)) ([598f033](598f033))
* **deps:** bump the types group with 6 updates ([#658](#658)) ([026a34d](026a34d))
* **deps:** bump type-fest from 4.7.1 to 4.8.1 ([#656](#656)) ([a054c2e](a054c2e))
* **deps:** bump type-fest from 4.8.1 to 4.8.2 ([#663](#663)) ([28644d0](28644d0))
* **deps:** bump typescript from 5.2.2 to 5.3.2 ([#660](#660)) ([b33b125](b33b125))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoinezanardi antoinezanardi

Labels
🔩 refactor Code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antoinezanardi