Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move getExpectedPlayersToPlay helper function to game play augmenter service #633

Closed
antoinezanardi opened this issue Nov 7, 2023 · 1 comment
Assignees
Labels
🔩 refactor Code change that neither fixes a bug nor adds a feature released

Comments

@antoinezanardi
Copy link
Owner

The function getExpectedPlayersToPlay is only used to augment the current game play of the game.

This place is this in the game play augmenter service.

It should also takes the allowed to vote players in count when game play action is VOTE or ELECT_SHERIFF.

@antoinezanardi antoinezanardi added the 🔩 refactor Code change that neither fixes a bug nor adds a feature label Nov 7, 2023
@antoinezanardi antoinezanardi self-assigned this Nov 7, 2023
antoinezanardi pushed a commit that referenced this issue Nov 15, 2023
## [1.22.0](v1.21.1...v1.22.0) (2023-11-15)

### 🚀 Features

* **docker:** docker file, dev and production docker compose files ([#616](#616)) ([8c5a943](8c5a943)), closes [#612](#612)
* **docker:** upload docker hub image with develop tag on develop branch push ([#619](#619)) ([2e4deb1](2e4deb1))
* **interactable-players:** interactable players with interactions for current game play ([#631](#631)) ([e230b3a](e230b3a))
* **interactable-players:** interactable players with interactions for current game play ([#644](#644)) ([289b3f9](289b3f9)), closes [#633](#633)

### 🧹 Chore

* **deps:** bump @faker-js/faker from 8.2.0 to 8.3.1 ([#642](#642)) ([058829a](058829a))
* **deps:** bump @fastify/static from 6.11.2 to 6.12.0 ([#620](#620)) ([8670ba6](8670ba6))
* **deps:** bump lint-staged from 15.0.2 to 15.1.0 ([#640](#640)) ([94b54d3](94b54d3))
* **deps:** bump mongoose from 7.6.3 to 7.6.4 ([#624](#624)) ([bbddedb](bbddedb))
* **deps:** bump mongoose from 7.6.4 to 8.0.0 ([#627](#627)) ([507028d](507028d))
* **deps:** bump semantic-release from 22.0.5 to 22.0.6 ([#625](#625)) ([10cb396](10cb396))
* **deps:** bump semantic-release from 22.0.6 to 22.0.7 ([#630](#630)) ([c632735](c632735))
* **deps:** bump the commitlint group with 2 updates ([#639](#639)) ([b13212a](b13212a))
* **deps:** bump the eslint group with 1 update ([#629](#629)) ([db6cb42](db6cb42))
* **deps:** bump the nest group with 2 updates ([#622](#622)) ([95caa1b](95caa1b))
* **deps:** bump the nest group with 2 updates ([#636](#636)) ([94e09c6](94e09c6))
* **deps:** bump the nest group with 5 updates ([#628](#628)) ([1b17eb3](1b17eb3))
* **deps:** bump the types group with 2 updates ([#641](#641)) ([e60f712](e60f712))
* **deps:** bump the types group with 3 updates ([#632](#632)) ([56162ed](56162ed))
* **deps:** bump the types group with 4 updates ([#626](#626)) ([8cb2b9f](8cb2b9f))
* **deps:** bump the types group with 6 updates ([#635](#635)) ([fc699f6](fc699f6))
* **deps:** bump ts-loader from 9.5.0 to 9.5.1 ([#643](#643)) ([b4b530e](b4b530e))
* **deps:** bump type-fest from 4.6.0 to 4.7.1 ([#638](#638)) ([790ca12](790ca12))
@antoinezanardi
Copy link
Owner Author

🎉 This issue has been resolved in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 refactor Code change that neither fixes a bug nor adds a feature released
Projects
None yet
Development

No branches or pull requests

1 participant