Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename game option isPowerlessIfInfected to isPowerlessOnWerewolvesSide #743

Closed
3 tasks done
antoinezanardi opened this issue Dec 13, 2023 · 1 comment
Closed
3 tasks done

Rename game option isPowerlessIfInfected to isPowerlessOnWerewolvesSide #743

antoinezanardi opened this issue Dec 13, 2023 · 1 comment
Assignees
@antoinezanardi
Labels
🔩 refactor Code change that neither fixes a bug nor adds a feature released

Comments

@antoinezanardi
Copy link
Owner

antoinezanardi commented Dec 13, 2023 •
edited

More generic name would be better for isPowerlessIfInfected with isPowerlessOnWerewolvesSide.

  • Rename isPowerlessIfInfected for options.piedPiper and description.
  • Rename isPowerlessIfInfected for options.prejudicedManipulator and description.
  • Rename isPowerlessIfInfected for options.bearTamer to doesGrowlOnWerewolvesSide and description.
@antoinezanardi antoinezanardi added the 🔩 refactor Code change that neither fixes a bug nor adds a feature label Dec 13, 2023
@antoinezanardi antoinezanardi self-assigned this Dec 13, 2023
@antoinezanardi antoinezanardi mentioned this issue Dec 13, 2023
Merged
antoinezanardi pushed a commit that referenced this issue Dec 19, 2023
@semantic-release-bot
chore(release): 1.26.0 [skip ci]
9c725af 
## [1.26.0](v1.25.0...v1.26.0) (2023-12-19)

### 🚀 Features

* **game-options:** actor additional cards count game option ([#747](#747)) ([5c6b062](5c6b062)), closes [#735](#735)
* **game-options:** actor not powerless on werewolves side game option ([#745](#745)) ([8a7f3a8](8a7f3a8)), closes [#734](#734)
* **servant:** devoted servant role ([#752](#752)) ([ee85bac](ee85bac)), closes [#672](#672)
* **thief:** chosen thief card is used when played ([#741](#741)) ([a6806ea](a6806ea)), closes [#727](#727)

### 🔩 Refactor

* **game-options:** rename powerless if infected to powerless on werewolves side ([#746](#746)) ([9423611](9423611)), closes [#743](#743)
* **game-play-validation:** use `canBeSkipped` variable for validating thief play ([#740](#740)) ([482cd53](482cd53)), closes [#724](#724)

### ✅ Tests

* **rusty-sword-knight:** acceptance test for powerless rusty sword knight ([#742](#742)) ([072ed25](072ed25)), closes [#731](#731)

### 🧹 Chore

* **deps:** bump semantic-release from 22.0.10 to 22.0.12 ([#738](#738)) ([df7c16b](df7c16b))
* **deps:** bump the eslint group with 1 update ([#757](#757)) ([4294657](4294657))
* **deps:** bump the eslint group with 1 update ([#762](#762)) ([f81b5a7](f81b5a7))
* **deps:** bump the nest group with 1 update ([#756](#756)) ([9843a9e](9843a9e))
* **deps:** bump the nest group with 5 updates ([#764](#764)) ([d488944](d488944))
* **deps:** bump the types group with 1 update ([#761](#761)) ([f27b285](f27b285))
* **deps:** bump the types group with 2 updates ([#736](#736)) ([919049a](919049a))
* **deps:** bump the types group with 2 updates ([#765](#765)) ([d5b5332](d5b5332))
* **github-actions:** bump github/codeql-action from 2 to 3 ([#753](#753)) ([fbb87c8](fbb87c8))
@antoinezanardi
Copy link
Owner Author

🎉 This issue has been resolved in version 1.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoinezanardi antoinezanardi

Labels
🔩 refactor Code change that neither fixes a bug nor adds a feature released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antoinezanardi