Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies and fix #27 #28

Merged
merged 2 commits into from
May 8, 2020
Merged

update dependencies and fix #27 #28

merged 2 commits into from
May 8, 2020

Conversation

antokara
Copy link
Owner

@antokara antokara commented May 8, 2020

fix(packages): update npm packages

  • update all npm packages to latest major versions
  • fix npm audit issues

fix(recaptcha v2 component): delayed render

  • modify index of dev and examples, to test and demo delayed render of v2 widget
  • fix comment in v2 component IState
  • rename checkComponentDidUpdate method of v2 component, to shouldRenderWidget and change comparison logic to check if previously rendered instead of change in providerContext.loaded
  • add componentDidMount lifecycle event method in v2 component to invoke shouldRenderWidget
  • refactor v2 component tests to smaller files
  • add v2 component tests for test with initial providerContext.loaded:true

fix #27

* update all npm packages to latest major versions
* fix npm audit issues
* modify index of dev and examples, to test and demo delayed render of v2 widget
* fix comment in v2 component IState
* rename checkComponentDidUpdate method of v2 component, to shouldRenderWidget and change comparison logic to check if previously rendered instead of change in providerContext.loaded
* add componentDidMount lifecycle event method in v2 component to invoke shouldRenderWidget
* refactor v2 component tests to smaller files
* add v2 component tests for test with initial providerContext.loaded:true

fix #27
@antokara antokara merged commit bab3d2d into master May 8, 2020
@antokara antokara deleted the update-and-fix branch May 8, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReCaptcha V2 is not rendered if provider and comsumer is not rendered at the same time
1 participant