Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refactor l1 cost and mint computations #4

Merged
merged 2 commits into from
Sep 5, 2023
Merged

fix: Refactor l1 cost and mint computations #4

merged 2 commits into from
Sep 5, 2023

Conversation

refcell
Copy link

@refcell refcell commented Sep 5, 2023

Description

Refactors the l1 cost computation and mint value account updates into EVMImpl functions.

@refcell refcell requested a review from clabby September 5, 2023 20:35
@refcell refcell self-assigned this Sep 5, 2023
@refcell refcell mentioned this pull request Sep 5, 2023
Merged
8 tasks
clabby
clabby approved these changes Sep 5, 2023
View reviewed changes
Copy link

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; One comment about the underflow throwing an error rather than silently saturating.

crates/revm/src/evm_impl.rs Outdated Show resolved Hide resolved
@refcell refcell merged commit ae76b7e into clabby/op-revm Sep 5, 2023
@refcell refcell deleted the refcell/refactors branch September 8, 2023 17:12
clabby added a commit that referenced this pull request Dec 2, 2023
@clabby
Merge pull request #4 from clabby/cl/auth-stuff
68e0dd7 
feat: `AUTH` updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@refcell @clabby