Added logic necessary to allow for a custom close button control to b… #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e passed like prev and next
antonKalinin
approved these changes
Mar 11, 2019
|
@MattConflitti Thanks for PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e passed like prev and next
The variable
closethat is destructured fromthis.props.controlsis never checked for being set to anything other thannullnor given an opportunity to be assigned thecontrolsobject. Your documentation implies that you should be able to inject a custom component for the close button, so I thought I would take a crack at fixing it. I tested this within my app and it works.