Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

reported version? #130

Closed
tisdall opened this issue Dec 21, 2018 · 2 comments · Fixed by #149
Closed

reported version? #130

tisdall opened this issue Dec 21, 2018 · 2 comments · Fixed by #149

Comments

@tisdall
Copy link

tisdall commented Dec 21, 2018

I messed up and accidentally had the INSTALLED_APPS order wrong. When I was trying to determine which collectstatic was working I tried using python manage.py collectstatic --version. However, even after I fixed the issue it was still reporting my Django version instead of the version of Collectfast.

Yes, it's a really small and pedantic thing, but --version should be reporting the version of Collectfast.

@antonagestam
Copy link
Owner

I'll happily review a pull request for this.

@antonagestam
Copy link
Owner

The implementation should probably override BaseCommand.get_version() and make it return something like "collectfast version: <version>".

https://docs.djangoproject.com/en/2.1/howto/custom-management-commands/#django.core.management.BaseCommand.get_version

antonagestam added a commit that referenced this issue Sep 29, 2019
- typing
- get_version(), fixes #130
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants