This repository has been archived by the owner on Jan 16, 2023. It is now read-only.
normalize path with public API #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you're welcome! although copying rather than modifying (or cherrypicking from) the pull request doesn't make me a contributor ;) but more seriously: are you publishing this as a release soon? That'd be great! |
|
@nschlemm I am sorry about that, but I had a hard time cherrypicking since there were so many other changes on that branch. If you want to we can start using a AUTHORS file and I could add you there. The contribution is much appreciated! I will try to get a release out soon! |
|
no worries! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #102
fixes #101
Using public API's as suggested by @nschlemm
Thanks for the contribution! 🍰