Make datetime.tzinfo non-optional for TZAware #233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that accessing
.tzinfo
on adatetime.datetime
object that has been narrowed toTZAware
has the typedatetime.tzinfo
instead ofdatetime.tzinfo | None
. This is safe because this check is already part of the predicate, ie by definition ofisinstance(_, TZAware)
.It also addresses #84 for
TZAware
andTZNaive
, by checking that accessing an attribute fromdatetime.datetime
does not raise a static type checking error.