Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added terraform_wrapper_module_for_each hook #376

Merged
merged 6 commits into from May 2, 2022

Conversation

antonbabenko
Copy link
Owner

@antonbabenko antonbabenko commented Apr 28, 2022

Fixes #202

To try this out, you can run it on various modules in terraform-aws-modules organization (e.g. https://github.com/terraform-aws-modules/terraform-aws-s3-bucket):

- id: terraform_wrapper_module_for_each

Please review the shell script and suggest improvements.

The produced result should be very similar to terraform-aws-modules/terraform-aws-ec2-instance#270

README.md Outdated Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Outdated Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Outdated Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Outdated Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Outdated Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Outdated Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Outdated Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Outdated Show resolved Hide resolved
@MaxymVlasov MaxymVlasov added feature New feature or request estimate/2days Need 2 work days to be done labels Apr 28, 2022
@antonbabenko
Copy link
Owner Author

Huge thanks for all the comments! Please take another look and approve/comment.

Copy link
Collaborator

@yermulnik yermulnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from several more or less minor comments I've left.
(approved in case you'd prefer to consider and fix later)

hooks/terraform_wrapper_module_for_each.sh Outdated Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Outdated Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Outdated Show resolved Hide resolved
hooks/terraform_wrapper_module_for_each.sh Outdated Show resolved Hide resolved
antonbabenko and others added 2 commits May 2, 2022 19:26
Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
@antonbabenko antonbabenko merged commit e4e9a73 into master May 2, 2022
@antonbabenko antonbabenko deleted the feat-add-wrapper-script branch May 2, 2022 17:59
antonbabenko pushed a commit that referenced this pull request May 2, 2022
# [1.71.0](v1.70.1...v1.71.0) (2022-05-02)

### Features

* Added terraform_wrapper_module_for_each hook ([#376](#376)) ([e4e9a73](e4e9a73))
@antonbabenko
Copy link
Owner Author

This PR is included in version 1.71.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimate/2days Need 2 work days to be done feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add terraform_wrapper to autogenerate module wrappers
4 participants