Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check how hard make hooks sh POSIX compatible #397

Closed
MaxymVlasov opened this issue Jun 10, 2022 · 5 comments
Closed

Check how hard make hooks sh POSIX compatible #397

MaxymVlasov opened this issue Jun 10, 2022 · 5 comments
Labels
estimate/1day Need 1 work day to be done feature New feature or request on-hold Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
Features implemen...

Comments

@MaxymVlasov
Copy link
Collaborator

MaxymVlasov commented Jun 10, 2022 •
edited

will help: https://github.com/dylanaraps/pure-sh-bible and #339 (comment)

Related issues that will not exist if make hooks POSIX compatible: https://github.com/antonbabenko/pre-commit-terraform/issues?q=is%3Aissue+sort%3Aupdated-desc+label%3Aarea%2FmacOS+
@MaxymVlasov MaxymVlasov added feature New feature or request estimate/1day Need 1 work day to be done labels Jun 10, 2022
@yermulnik
Copy link
Collaborator

Okay.... https://mywiki.wooledge.org/BashPitfalls =)

@antonbabenko
Copy link
Owner

:trollface:

@MaxymVlasov MaxymVlasov mentioned this issue Aug 2, 2022
Open
@MaxymVlasov
Copy link
Collaborator Author

Depends on #303

@MaxymVlasov MaxymVlasov added the on-hold Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 15, 2022
@MaxymVlasov
Copy link
Collaborator Author

@yermulnik Then, I suppose we can close this issue and stick with bash 3.2.57?

image

https://github.com/antonbabenko/pre-commit-terraform/pull/620/files#r1485091544

@yermulnik
Copy link
Collaborator

@MaxymVlasov I guess we indeed can and, if we explicitly rely upon bash in shebang strings, care only about cross-compatibility between Bash v3 and more modern versions of Bash.

@yermulnik yermulnik closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
estimate/1day Need 1 work day to be done feature New feature or request on-hold Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
Features implementing and cleanup wit...
Development

No branches or pull requests
3 participants
@antonbabenko @yermulnik @MaxymVlasov