Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix grep: warning: stray \ before / which pop-up in grep 3.8 #625

Merged
merged 1 commit into from Feb 16, 2024

Conversation

MaxymVlasov
Copy link
Collaborator

@MaxymVlasov MaxymVlasov commented Feb 16, 2024

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

Remove \ before \/ as grep 3.8 don't like it and re.search don't mind about it

Fix #618

How can we test changes

These exclude patterns in pre-commit used by Python re.search, and it is okay with that change

https://regex101.com/
image

repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: 7e213b5c4202015ee5f5ee311cd6277b5ffd0775
 ...

@MaxymVlasov
Copy link
Collaborator Author

@dmitry-mightydevops feel free to confirm that this fix works for you

@MaxymVlasov MaxymVlasov changed the title fix: grep: warning: stray \ before / which pop-up in grep 3.8 fix: Fix grep: warning: stray \ before / which pop-up in grep 3.8 Feb 16, 2024
@dmitry-mightydevops
Copy link

thanks for the quick fix!
worked like a charm!

➜ pre-commit run --all-files --hook-stage push terragrunt_validate
Terragrunt validate......................................................Failed
- hook id: terragrunt_validate
- exit code: 1

Success! The configuration is valid.

INFO[0000] Downloading Terraform configurations from ╷
│ Error: Unsupported Terraform Core version
│ 
│   on config.tf line 3, in terraform:
│    3:   required_version = "1.7.2"
│ 
│ This configuration does not support Terraform version 1.7.3. To proceed,
│ either choose another supported Terraform version or update this version
│ constraint. Version constraints are normally set for good reason, so
│ updating the constraint may lead to other errors or unexpected behavior.

@MaxymVlasov MaxymVlasov merged commit e1a93b2 into master Feb 16, 2024
5 of 8 checks passed
@MaxymVlasov MaxymVlasov deleted the fix/GH-618 branch February 16, 2024 22:26
antonbabenko pushed a commit that referenced this pull request Feb 16, 2024
## [1.86.1](v1.86.0...v1.86.1) (2024-02-16)

### Bug Fixes

* `grep: warning: stray \ before /` which pop-up in `grep 3.8` ([#625](#625)) ([e1a93b2](e1a93b2))
@antonbabenko
Copy link
Owner

This PR is included in version 1.86.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimate/1h Need 1 hour to be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fedora, grep 3.8] grep: warning: stray \ before /
4 participants