fix(terraform_providers_lock): Require terraform init (and terraform_validate hook) run when only lockfile changed
#649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxymVlasov
added
bug_with_workaround
yermulnik
approved these changes
Mar 22, 2024
Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
MaxymVlasov
changed the title
terraform_providers_lock): Require t init (and terraform_validate) run when only lockfile changedterraform_providers_lock): Require terraform init (and terraform_validate hook) run when only lockfile changed
antonbabenko
pushed a commit
that referenced
this pull request
Mar 22, 2024
## [1.88.3](v1.88.2...v1.88.3) (2024-03-22) ### Bug Fixes * **`terraform_providers_lock`:** Require `terraform init` (and `terraform_validate` hook) run when only lockfile changed ([#649](#649)) ([02c1935](02c1935))
|
This PR is included in version 1.88.3 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put an
xinto the box if that apply:Description of your changes
When the terraform root module contains any child module it requires
terraform initto run to be able to successfully run the provider lock operation.Previously,
terraform initwas interraform_providers_lockhook too, but moved out to be only interraform_validate, because there was little sense to try to lock anything that was code invalid.If we return
terraform initback toterraform_providers_lock- major changes in providers that remove resources etc. can be successfully written to lockfile without any checks, as such checks done interraform_validateWorkaround till the release of that stuff
Add
files: (\.tf|\.tfvars|\.terraform\.lock\.hcl)$toterraform_validatehook call