feat(time_field): Add event in handle onChange, add inputRef #6
Conversation
src/index.js
Outdated
| @@ -59,14 +60,14 @@ export default class TimeField extends React.Component { | |||
| showSeconds: PropTypes.bool, | |||
| input: PropTypes.element, | |||
| colon: PropTypes.string, | |||
| style: PropTypes.object | |||
| style: PropTypes.object, | |||
There was a problem hiding this comment.
Hi @MrChe,
Could you, please, run npm run prettier and add the changes to the PR, to follow preconfigured style. Thank you!
src/index.js
Outdated
| value, | ||
| style, | ||
| onChange: onChangeHandler | ||
| defaultValue, |
There was a problem hiding this comment.
As I see, there is no need to pass defaultValue separately, because all ...props are already passed to the input above (...props, line 177)
src/index.js
Outdated
| }); | ||
| } | ||
|
|
||
| return ( | ||
| <input | ||
| type="text" | ||
| {...props} | ||
| colon={colon} | ||
| defaultValue={defaultValue} |
There was a problem hiding this comment.
The same there, as I see, there is no need to pass defaultValue separately, because all ...props are already passed to the HTML input above ({...props} line 190)
src/index.js
Outdated
| }); | ||
| } | ||
|
|
||
| return ( | ||
| <input | ||
| type="text" | ||
| {...props} | ||
| colon={colon} |
There was a problem hiding this comment.
HTML input doesn't have colon property, so this may cause a warning
src/index.js
Outdated
| value, | ||
| style, | ||
| onChange: onChangeHandler | ||
| defaultValue, | ||
| ref: inputRef, |
There was a problem hiding this comment.
I can imagine the situation where you need to pass inputRef to the cloned element.
I'm trying to figure out can the same problem be solved by replacing this code:
<TimeField input={<MyInput />} inputRef={myRef} />By this one:
<TimeField input={<MyInput ref={myRef} />} />?
There was a problem hiding this comment.
inputRef need only native DOM input, maybe i don't understand your code
src/index.js
Outdated
| const onChangeHandler = (event) => this.onInputChange(event, (v) => onChange(v)); | ||
| const { value } = this.state; | ||
| const { onChange, style, showSeconds, input, inputRef, colon, defaultValue, ...props } = this.props; //eslint-disable-line no-unused-vars | ||
| const onChangeHandler = (event) => this.onInputChange(event, (v) => onChange(event, v)); |
|
Hi @MrChe, |
Add `event` for handle onChange. Add inputRef for native DOM element input. fix(index):delete other props
leonidkuznetsov18
force-pushed
the
feature/time_field
branch
from
fcb81d2
to
1ce6fa4
Compare
|
Hello @MrChe ! I need inputRef too but this PR is really old and cannot be merged, maybe we could just close this one so I can open another one and add it myself ? Thanks ! |
|
Just published https://www.npmjs.com/package/react-simple-timefield/v/3.2.0 with new |
Add
eventfor handle onChange. Add inputRef for native DOM element input.