fix(node): fix global URLSearchParams var type for TS 3.7.x compatibi…

…lity closes DefinitelyTyped#58562 relates DefinitelyTyped#34960 DefinitelyTyped#58277
antongolub-forks · Feb 3, 2022 · 69cfafd · 69cfafd
1 parent 6c720eb
commit 69cfafd
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 20 deletions.
diff --git a/types/node/url.d.ts b/types/node/url.d.ts
@@ -875,11 +875,16 @@ declare module 'url' {
          * https://nodejs.org/api/url.html#class-urlsearchparams
          * @since v10.0.0
          */
-        var URLSearchParams: {
-            prototype: URLSearchParams;
-            new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
-            toString(): string;
-        };
+        var URLSearchParams: typeof globalThis extends { SpeechRecognitionError: infer SpeechRecognitionError } ?
+            // For TS <= 3.8.2 compatibility
+            {
+                prototype: URLSearchParams;
+                new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
+            }: {
+                prototype: URLSearchParams;
+                new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
+                toString(): string;
+            };
     }
 }
 declare module 'node:url' {

diff --git a/types/node/v12/url.d.ts b/types/node/v12/url.d.ts
@@ -134,10 +134,15 @@ declare module 'url' {
          * https://nodejs.org/api/url.html#class-urlsearchparams
          * @since v10.0.0
          */
-        var URLSearchParams: {
-            prototype: URLSearchParams;
-            new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
-            toString(): string;
-        };
+        var URLSearchParams: typeof globalThis extends { SpeechRecognitionError: infer SpeechRecognitionError } ?
+            // For TS <= 3.8.2 compatibility
+            {
+                prototype: URLSearchParams;
+                new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
+            }: {
+                prototype: URLSearchParams;
+                new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
+                toString(): string;
+            };
     }
 }
diff --git a/types/node/v14/url.d.ts b/types/node/v14/url.d.ts
@@ -133,11 +133,16 @@ declare module 'url' {
          * https://nodejs.org/api/url.html#class-urlsearchparams
          * @since v10.0.0
          */
-        var URLSearchParams: {
-            prototype: URLSearchParams;
-            new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
-            toString(): string;
-        };
+        var URLSearchParams: typeof globalThis extends { SpeechRecognitionError: infer SpeechRecognitionError } ?
+            // For TS <= 3.8.2 compatibility
+            {
+                prototype: URLSearchParams;
+                new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
+            }: {
+                prototype: URLSearchParams;
+                new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
+                toString(): string;
+            };
     }
 }
 declare module 'node:url' {

diff --git a/types/node/v16/url.d.ts b/types/node/v16/url.d.ts
@@ -835,11 +835,16 @@ declare module 'url' {
          * https://nodejs.org/api/url.html#class-urlsearchparams
          * @since v10.0.0
          */
-        var URLSearchParams: {
-            prototype: URLSearchParams;
-            new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
-            toString(): string;
-        };
+        var URLSearchParams: typeof globalThis extends { SpeechRecognitionError: infer SpeechRecognitionError } ?
+            // For TS <= 3.8.2 compatibility
+            {
+                prototype: URLSearchParams;
+                new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
+            }: {
+                prototype: URLSearchParams;
+                new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
+                toString(): string;
+            };
     }
 }
 declare module 'node:url' {